Skip to content

add C++20 module #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

add C++20 module #644

wants to merge 12 commits into from

Conversation

Arthapz
Copy link

@Arthapz Arthapz commented Oct 31, 2024

No description provided.

@Arthapz Arthapz force-pushed the master branch 3 times, most recently from e354e1a to bcf8b86 Compare October 31, 2024 13:26
@brandl-muc
Copy link
Contributor

Given that constexpr has evolved substantially it might be a good idea to name the macro PUGIXML_CONSTEXPR11.
That would allow e.g. to have functions as constexpr in C++17 mode that could not be constexpr with C++11.

@Arthapz
Copy link
Author

Arthapz commented Oct 31, 2024

Given that constexpr has evolved substantially it might be a good idea to name the macro PUGIXML_CONSTEXPR11. That would allow e.g. to have functions as constexpr in C++17 mode that could not be constexpr with C++11.

good catch

@Arthapz Arthapz force-pushed the master branch 4 times, most recently from b0fbfbc to d57ccaf Compare October 31, 2024 17:05
@Arthapz
Copy link
Author

Arthapz commented Oct 31, 2024

here's a demo for C++20 module

https://github.com/Arthapz/pugixml_module_test

pugixml

@aniol-marin
Copy link

What's the state on this PR? Any chance it can be discussed further?

@Arthapz
Copy link
Author

Arthapz commented May 11, 2025

(i rebased on master)

@Arthapz Arthapz force-pushed the master branch 3 times, most recently from 2eb3171 to 7d73fff Compare May 11, 2025 15:42
@Arthapz Arthapz force-pushed the master branch 2 times, most recently from c01b897 to 0f3092a Compare May 11, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants