Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files 841 handle open with docs over size failures #404

Open
wants to merge 12 commits into
base: devel
Choose a base branch
from

Conversation

CataldoMazzilli
Copy link
Member

@CataldoMazzilli CataldoMazzilli commented Sep 30, 2024

Add translations:

  • snackbar.openWithDocs.error.exceedSizeLimit -> The item exceeds the size limit allowed and cannot be opened.
  • snackbar.openWithDocs.error.pleaseDownload -> To view the item, please download it on your device
  • snackbar.openWithDocs.error.exceedSizeLimit.actionLabel -> Ok

@CataldoMazzilli CataldoMazzilli requested a review from a team as a code owner September 30, 2024 10:28
@CataldoMazzilli CataldoMazzilli self-assigned this Sep 30, 2024

This comment has been minimized.

beawar
beawar previously approved these changes Oct 2, 2024
src/carbonio-files-ui-common/hooks/useHeaderActions.ts Outdated Show resolved Hide resolved
src/carbonio-files-ui-common/hooks/useHeaderActions.ts Outdated Show resolved Hide resolved

This comment has been minimized.

beawar
beawar previously approved these changes Oct 2, 2024
rodleyorosa
rodleyorosa previously approved these changes Oct 3, 2024
@beawar beawar dismissed stale reviews from rodleyorosa and themself via b51cc66 October 18, 2024 12:22
beawar
beawar previously approved these changes Oct 18, 2024

This comment has been minimized.

rodleyorosa
rodleyorosa previously approved these changes Oct 28, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 87.30% Coverage (85.40% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.60% Estimated after merge)

Project ID: carbonio-files-ui

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants