hive: add option to persistently disallow substitutes #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pks-t
force-pushed
the
pks-node-no-substitute
branch
2 times, most recently
from
e1ef604 to
9df7194
Compare
pks-t
force-pushed
the
pks-node-no-substitute
branch
from
9df7194 to
5d75fd5
Compare
In the next commit, we're about to introduce a new per-node option that
disables substitutes by default. If set, the "--no-substitutes" command
line option shall continue to override that default, following our usual
rules of preference.
In order to override the default, we're also going to introduce a new
"--use-substitutes" option. But this will require us to distinguish the
cases where either of these flags has been set from the case where none
of them were passed:
- "--no-substitutes" overrides the per-node option and disables
substitutes.
- "--use-substitutes overrides the per-node option and enables
substitutes.
- No flag will cause the per-node option to kick in.
Refactor the code so that we use an `Option<bool>`. This allows us to
easily discern the last case in subsequent commits.
While Colmena provides a "--no-substitutes" flag to disable substitutes, there is no way to persistently disable their use. Such an option would be useful though in cases where one is deploying to a node that does not have an internet connection, which would otherwise fail if the flag was not given. Introduce a new per-node "deployment.noSubstitute" option that allows you to persistently disable the use of substitutes. This option defaults to "false", which is in line with the current default. Furthermore, the option gets overridden by the "--no-substitutes" command line flag.
Introduce a new "--use-substitutes" option. While the use of substitutes is enabled by default, they can be disabled per-node by setting the "deployment.noSubstitutes" option. If so, specifying the new flag will override that option and enable substitutes regardless of the per-node option.
pks-t
force-pushed
the
pks-node-no-substitute
branch
from
5d75fd5 to
55b5a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Colmena provides a "--no-substitutes" flag to disable substitutes,
there is no way to persistently disable their use. Such an option would
be useful though in cases where one is deploying to a node that does not
have an internet connection, which would otherwise fail if the flag was
not given.
Introduce a new per-node "deployment.noSubstitute" option that allows
you to persistently disable the use of substitutes. This option defaults
to "false", which is in line with the current default. Furthermore, the
option gets overridden by the "--no-substitutes" command line flag.
Part of #187.