Remove cImport #20643
Closed
Remove cImport #20643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and their tests.
andrewrk
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Too soon!
- We need to migrate some projects successfully to the build step. I tried migrating tetris just now when I saw your PR and it is awkward. The build step needs work. Let's wait until a release of Zig is out that has both the improved translate-c build step and
@cImportand then that can be a nice time for people to migrate. - Many of those deleted test cases should be preserved. They should be migrated to the new thing and kept alive.
- The build system documentation guide should be provided first so that people have something to look at when migrating.
|
Let's revisit when the "blockers" section of #20630 is solved (added just now) and 0.14.0 is released. |
Okay, I'll try taking a look at those then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.