Take eagerness into account when deduplicating dependencies #21773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21771
If the same dependency is first discovered as lazy and then later as eager, the existing entry needs to be updated to eager in order for
b.dependency()
to work.Tested against the repro in the linked issue. With a master build of Zig it adds an
available
decl to the generateddependencies.zig
, which makes the build system consider it lazy. With this fix the decl is absent and the dependency is correctly considered eager.