feat: remove vector data when corresponding cache data expires #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kxbnb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Welcome @kxbnb! It looks like this is your first PR to zilliztech/GPTCache 🎉 |
Signed-off-by: Emmanuel Ferdman <[email protected]> Signed-off-by: karthik <[email protected]>
Signed-off-by: karthik <[email protected]>
…been added (zilliztech#669) I think that using LLM for verification can yield better results in some cases where quality requirements are higher. Especially in the customer service field and the like, other users' questions may lead to privacy leaks or mention other brands, thus causing interference and so on. In terms of specific details, I maintained the operation of openai==0.28.0 on the interface and was compatible with the operation of openai>1.0.0 and above. I have added the test case, the example test file, and updated the example/readme.md. I upgraded the version of onnxruntime to 1.21.1 because the previous version 1.14.0 is no longer in use. Signed-off-by: karthik <[email protected]>
- Add logic in adapt() and aadapt() to delete vector data when get_scalar_data returns None - Addresses issue zilliztech#632 for cleaning up orphaned vector data in Redis TTL scenarios - Ensures consistency between scalar and vector stores Signed-off-by: karthik <[email protected]>
- Added test_vector_cleanup_on_expired_cache to verify issue zilliztech#632 fix - Mocks data manager to simulate vector data without scalar data - Ensures v.delete() is called when cache_data is None Signed-off-by: karthik <[email protected]>
kxbnb
force-pushed
the
feature/remove-expired-vector-data
branch
from
0bd2ecf to
1b0e8ac
Compare
Author
|
/assign @xiaofan-luan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add automatic cleanup of vector data when corresponding cache data expires to fix orphaned vectors in Redis TTL scenarios.
Changes
gptcache/adapter/adapter.pyin bothadapt()andaadapt()functionschat_cache.data_manager.v.delete([search_data[1]])whencache_data is NoneValidation
test_vector_cleanup_on_expired_cacheto verify the fixTesting
Closes #632