Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the milvus pkg version and skip the env for the milvus param #136

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Sep 27, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.49%. Comparing base (2045637) to head (06921aa).

Files with missing lines Patch % Lines
core/reader/etcd_op.go 14.28% 6 Missing ⚠️
core/reader/replicate_channel_manager.go 0.00% 3 Missing ⚠️
core/util/milvus_param.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   59.56%   59.49%   -0.07%     
==========================================
  Files          63       63              
  Lines        7958     7964       +6     
==========================================
- Hits         4740     4738       -2     
- Misses       2912     2920       +8     
  Partials      306      306              
Flag Coverage Δ
59.49% <9.09%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/reader/data_barrier.go 100.00% <ø> (ø)
server/server.go 78.57% <ø> (ø)
core/util/milvus_param.go 0.00% <0.00%> (ø)
core/reader/replicate_channel_manager.go 52.69% <0.00%> (-0.12%) ⬇️
core/reader/etcd_op.go 58.33% <14.28%> (-0.42%) ⬇️

@SimFG SimFG merged commit 9c8f9c7 into zilliztech:main Sep 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants