Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the target info to the ts manager key #148

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Oct 22, 2024

No description provided.

@SimFG SimFG force-pushed the main branch 2 times, most recently from 0e25eaf to 9b94963 Compare October 22, 2024 11:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.68%. Comparing base (3ea1ebf) to head (9b94963).

Files with missing lines Patch % Lines
core/reader/ts_manager.go 84.84% 5 Missing ⚠️
core/reader/replicate_channel_manager.go 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   59.59%   59.68%   +0.08%     
==========================================
  Files          63       63              
  Lines        8120     8145      +25     
==========================================
+ Hits         4839     4861      +22     
- Misses       2963     2966       +3     
  Partials      318      318              
Files with missing lines Coverage Δ
server/cdc_impl.go 60.67% <100.00%> (+0.03%) ⬆️
core/reader/replicate_channel_manager.go 54.95% <92.30%> (+0.47%) ⬆️
core/reader/ts_manager.go 76.88% <84.84%> (-0.84%) ⬇️

@SimFG SimFG force-pushed the main branch 2 times, most recently from eaaee1a to 74073f4 Compare October 22, 2024 13:03
@SimFG SimFG merged commit 6fc5647 into zilliztech:main Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants