Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Etcd podDisruptionBudget selection based on Kubernetes Version #82

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rachit-Chaudhary11
Copy link
Contributor

What this PR does / why we need it:

Higher versions of Kubernetes fail to work with etcd's: policy/v1beta1, hence a configurable policy based on the kubernetes version is needed.

Error Message: No matches for kind "PodDisruptionBudget" in version "policy/v1beta1".
Reference PR: #74

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

Signed-off-by: Rachit-Chaudhary11 <[email protected]>
Signed-off-by: Rachit-Chaudhary11 <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rachit-Chaudhary11
To complete the pull request process, please assign loveeachday after the PR has been reviewed.
You can assign the PR to them by writing /assign @loveeachday in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Rachit-Chaudhary11 <[email protected]>
@Rachit-Chaudhary11
Copy link
Contributor Author

Reference PR : #74

@Rachit-Chaudhary11
Copy link
Contributor Author

@LoveEachDay @haorenfsa kindly take a look at this PR

@haorenfsa
Copy link
Collaborator

Hi team, can I get some updates on this PR?

@Rachit-Chaudhary11 Hi, sry for the delay. The teem are busy with other stuff. Still, as I mentioned in #74, I insist on maintaining the etcd chart code within this repo like we're doing for MinIO. I shall launch another PR to do that. And I think we could merge this PR afterwards.

Thank you again for your contribution.

We are awaiting for this fix as it will cause an issue during our migration ot latest milvus instance

You can solve this by walkaround make a milvus-helm chart package of your own repo.

@haorenfsa
Copy link
Collaborator

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants