Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the initJob's backoff limit configurable via values.yaml #147

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Make the initJob's backoff limit configurable via values.yaml #147

merged 3 commits into from
Nov 27, 2023

Conversation

jessebot
Copy link
Contributor

Definition of Ready

This makes the initJob's backoffLimit configurable, so that it will restart as much as needed while waiting for mounted database TLS secrets to become available. This helps when databases are slower to provision than zitadel expects if you're deploying both at the same time.

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jessebot 🙏

@eliobischof eliobischof merged commit 611a1b1 into zitadel:main Nov 27, 2023
8 checks passed
@jessebot jessebot deleted the patch-1 branch November 27, 2023 13:57
@jessebot
Copy link
Contributor Author

No problem! Thank you to the rest of the zitadel team for always being so responsive and helpful!

kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
…l#147)

* Update values.yaml - make the backoff limit configurable

* Update Chart.yaml - bump chart a patch version after making initJob.backoffLimit configurable

* Update initjob.yaml - make spec.backoffLimit value configurable in values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants