refactor and tidy home / tilde expansion #441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjex
force-pushed
the
refactor-tilde-expansion
branch
from
05da552 to
774a604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added tilde expansion for note.template so users can share template files between notebooks in #431.
We however overlooked that tilde / home dir expansion was already being implemented in isolation for the global notebook directory in
container.go.I've refactored that code into the function @hugo created, and also made a few optimisations to it (and renamed it as it now expands more than just tildes).
I made a decision to not pass up the
errfromResolveHomeDir()and wrap it instead, as there is only one error that would be passed up, so it makes each call to it unnecessarily verbose? Very open and interested to know if that's not the best idea.Otherwise, am I overlooking anything, have I overdone / underdone anything, or is it looking alright?