Skip to content

Windows support to edit new files #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Conversation

apraga
Copy link
Contributor

@apraga apraga commented Jan 29, 2025

Fixes #499 by removing /dev/tty on Windows

Fixes #499 by removing /dev/tty on Windows
@tjex
Copy link
Member

tjex commented Feb 9, 2025

I can test this at work. But may take a bit to get the chance. sorry.

@mcDevnagh
Copy link
Member

@apraga please double check that your branch still works after my changes

@apraga
Copy link
Contributor Author

apraga commented Feb 28, 2025 via email

@mcDevnagh mcDevnagh merged commit 64ad7f4 into zk-org:main Feb 28, 2025
3 checks passed
@tjex
Copy link
Member

tjex commented Mar 11, 2025

I just tested at work on windows. With the latest build I can't run zk new or open a file.
I get the operation aborted by editor error.

@apraga Can you reply here with how you're defining the editor in config.toml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot open a new file in editor in Windows
3 participants