fix: Ctrl+E does no longer create new notes in chooser #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a --bind behavior change in fzf 0.53.0 which could be causing the error. execute action is for executing an external program in the alternate screen without leaving fzf. In zk abort+execute was used to close fzf and open a zk instance. become action is similar to execute, but it replaces the current fzf process with the specified command using execve(2) system call. This should have similar behavior to the previous abort+execute action. junegunn/fzf#3865 https://github.com/junegunn/fzf/blob/710ebdf9c14e0c88b0cfc843ce08edcdd4554571/man/man1/fzf.1#L1785-L1789 junegunn/fzf@6ea38b4
mcDevnagh
approved these changes
Feb 28, 2025
|
tested and looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a --bind behavior change in fzf 0.53.0 which could be causing the error.
execute action is for executing an external program in the alternate screen without leaving fzf. In zk abort+execute was used to close fzf and open a zk instance.
become action is similar to execute, but it replaces the current fzf process with the specified command using execve(2) system call.
This should have similar behavior to the previous abort+execute action.
junegunn/fzf#3865
https://github.com/junegunn/fzf/blob/710ebdf9c14e0c88b0cfc843ce08edcdd4554571/man/man1/fzf.1#L1785-L1789
junegunn/fzf@6ea38b4
fixes: #518