chore: Copy changes and remove timelock field #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wryonik
commented
Jan 7, 2025
wryonik
commented
- Update "Gnosis Safe" -> "Safe"
- Remove "Under Audit" message
- Add explaination for burner wallet
- Remove timelock field from the burner wallet flow
Divide-By-0
temporarily deployed
to
shubhamgupta2956/zk-1061-recovery-demo-small-improvements - prove.email/recovery PR #11
Render
Destroyed
- Update "Gnosis Safe" -> "Safe" - Remove "Under Audit" message - Add explaination for burner wallet - Remove timelock field from the burner wallet flow
wryonik
force-pushed
the
shubhamgupta2956/zk-1061-recovery-demo-small-improvements
branch
from
dd75a23 to
767122d
Compare
Divide-By-0
temporarily deployed
to
shubhamgupta2956/zk-1061-recovery-demo-small-improvements - prove.email/recovery PR #11
Render
Destroyed
JohnGuilding
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Approving but these linting errors should be fixed @wryonik
| @@ -63,7 +63,7 @@ const GuardianSetup = () => { | |||
| const [loading, setLoading] = useState(false); | |||
|
|
|||
| // 0 = 2 week default delay, don't do for demo | |||
| const [recoveryDelay, setRecoveryDelay] = useState(1); | |||
| const [recoveryDelay, setRecoveryDelay] = useState(0); | |||
There was a problem hiding this comment.
Note for future changes, the production module has a minimum delay of 6 hours so this would need to be set to 6 hours under the hood. A small info message could be added when recovery is processed to tell the user to come back in 6 hours (kind of bad UX but the minimum delay is a useful security feature and it's needed as input to constructor, which impacts create2 address. So having consistent addresses means that we need this set to the same as the non-testnet version)
|
@wryonik can this be merged once linting and formatting is fixed? |
|
Replaced by #13 |
JohnGuilding
deleted the
shubhamgupta2956/zk-1061-recovery-demo-small-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.