Expose zlib constants for backwards compat #747 #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad0
force-pushed
the
mz_compat_zlib
branch
from
7f76835
to
f1f89a3
Compare
nmoinvaz
reviewed
Dec 17, 2023
nmoinvaz
reviewed
Dec 17, 2023
brad0
force-pushed
the
mz_compat_zlib
branch
from
f1f89a3
to
25ff004
Compare
|
From the CI: D:\a\minizip-ng\minizip-ng\mz_compat.h(19,10): fatal error C1083: Cannot open include file: 'zlib.h':
No such file or directory [D:\a\minizip-ng\minizip-ng\test\gtest_minizip.vcxproj] |
|
I could be wrong, but I think this CMake: Lines 713 to 714 in ef3ef9a needs to add |
|
Should I wait on this PR to make a new release? |
Building a project that had an internal copy of minizip 1.x, but preferring an external library, with minizip 4.x showed that the compat layer was not exposing some constants from zlib that minizip 1.x headers did.
brad0
force-pushed
the
mz_compat_zlib
branch
from
25ff004
to
0f8cf66
Compare
Go for 4.0.4. |
|
For information, minizip-ng 4.0.7 has been released (2024-06-15). |
This was referenced Oct 30, 2024
Coeur
suggested changes
Nov 1, 2024
Comment on lines
+714
to
+716
| $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}> | ||
| ${ZLIB_SOURCE_DIR} | ||
| ${ZLIB_BINARY_DIR}) |
There was a problem hiding this comment.
From my experiments, that part isn't needed. It's actually causing extra build issues (for Windows).
I came up with a solution that builds in #815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a project that had an internal copy of minizip 1.x, but
preferring an external library, with minizip 4.x showed that the
compat layer was not exposing some constants from zlib that
minizip 1.x headers did.