Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold-tap feature to hold the hold key until hold-tap decision #1393

Closed
Sixzero opened this issue Jul 22, 2022 · 9 comments
Closed

Hold-tap feature to hold the hold key until hold-tap decision #1393

Sixzero opened this issue Jul 22, 2022 · 9 comments
Labels
behaviors enhancement New feature or request

Comments

@Sixzero
Copy link

Sixzero commented Jul 22, 2022

So I read over all the open:issues whether there is already a proposal for this, and I found none.

Homerows are cool.

Whynot take it one step further by providing SHIFT homerow one additional functionality?

  • Basically we could hold down the SHIFT instantly on holding down our homerow key(F) and not only when some other keys are getting pressed.

Current hold-tap solutions decide about modifiers when other key was pressed, which works really well, if you use ZMK keyboards, but not when want to use the SHIFT homerow with non-ZMK peripherals like a mouse.

If the modifier key would get instantly pressed, it wouldn't disturb basically anything, except for GUI mod or maybe ALT mod, but other times there is no trigger usually attached for just holding down SHIFT in any softwares.

Others suggested to create a specific layer for gaming, since the problem came up with playing a game and SHIFT + mouse cordination of units is not that easy with ZMK keyboard, but on this gamer layer the problem is still not solved, since I would sometimes need the F key, and not just an &kp SHIFT key, so we basically lose a key, which is not an option for few key keyboards.

In theory this this sounds easy to implement, since we have already other hold-tap solutions, nearly the exact solution, of the one requested. One small modification is necessary is that, we hold the mod key until there is another key is getting pressed(simultaneously). Otherwise everything work the same as it works now.
Would love to know how easy/hard to implement this.

Tl;dr:
We need SHIFT homerow a special hold-tap, with instant mod press and not only decided on other key press.

@Sixzero
Copy link
Author

Sixzero commented Jul 22, 2022

It could be not a flavor, but another label, called "modflavor = zero-hold" or "modflavor = instant-hold" or anything like that.

This modflavor adds changes the modifier behavior for any of the hold flavors.

Current solution could be called "modflavor = onpress", meaning mod is only decided on other key presses.

@Sixzero Sixzero changed the title New and I expect, very important hold-tap feature New and I expect, very important hold-tap feature or mod_flavor? Jul 22, 2022
@Sixzero
Copy link
Author

Sixzero commented Jul 22, 2022

@urob in discord proposed this macro as a solution, which is not far from what I am trying to achieve:
<&macro_press &kp LEFT_SHIFT>,
<&macro_press &mt LEFT_SHIFT F>`,
<&macro_pause_for_release>,
<&macro_release &mt LEFT_SHIFT F>,
<&macro_release &kp LEFT_SHIFT>

@ManaHarbour proposed also another solution: retro-tap with 0 ms tapping term.

Going to try both, and see what works. :)

@Sixzero
Copy link
Author

Sixzero commented Jul 22, 2022

The retro-tap solution seem a little too different from the non-retro-tap holdtap solutions.

The macro one seem working, but not sure, there is definitely delay before it pressing the shift, that is what I feel.

@caksoylar caksoylar added enhancement New feature or request behaviors labels Jul 22, 2022
@Sixzero Sixzero changed the title New and I expect, very important hold-tap feature or mod_flavor? Hold-tap feature to hold the hold key until hold-tap decision Jul 22, 2022
@andrewjrae
Copy link
Contributor

I think this could probably just be a boolean option hold-while-undecided.

@Sixzero
Copy link
Author

Sixzero commented Jul 24, 2022

Wow, that was a fast solution, going to test it!

@Sixzero
Copy link
Author

Sixzero commented Jul 24, 2022

hold-while-undecided that it won't release the SHIFT sometimes.
Probably, it releases mod key on the tap press only? so if the shift was triggered then it is not getting released?

@Sixzero
Copy link
Author

Sixzero commented Jul 24, 2022

I use it with balanced flavor and taping-term-ms 200 exceded, so I press the behaviour button for more then 200ms, also the behavious has no retro-tap on.

Now I test 2 cases:

  • If retrotap is enabled.
  • If I use amcro to release the SHIFT on press end.

@Sixzero
Copy link
Author

Sixzero commented Aug 1, 2022

I think it is fully done, in Niconway's dev branch, so I close the issue, until it gets its reviewed.

@theol0403
Copy link
Contributor

@Sixzero can you give #1811 a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviors enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants