feat(behaviors): hold-tap hold while undecided

[theol0403]

This PR builds on the changes from #1398 and attempts to implement @okke-formsma 's suggestions. Addresses #1393.

New Properties:

hold-while-undecided

If enabled, the hold behavior will immediately be held on hold-tap press, and will release before the tap behavior is sent.

hold-while-undecided-linger

If your tap behavior activates the same modifier as the hold behavior, and you want to avoid a double tap when transitioning from the hold to the tap, you can use hold-while-undecided-linger. When enabled, the hold behavior will continue to be held until after the tap behavior is released. For example, if the hold is &kp LGUI and the tap is &sk LGUI, then with hold-while-undecided-linger enabled, the host will see LGUI held down continuously until the sticky key is finished, instead of seeing a release and press when transitioning from hold to sticky key.

Discussion

I did my best to implement the suggestions in #1398 (comment). However, some of them seemed unnecessary, and my implementation ended up looking quite like @nickconway 's. There seemed to be no benefit to adding STATUS_UNDECIDED_INITIAL_HOLD, as it wasn't used in the logic to decide whether to hold, and it was just treated identically to STATUS_UNDECIDED.

I am not sure about the name of hold-while-undecided-linger, any suggestions? Maybe hold-while-undecided-release-deferred or hold-while-undecided-around-tap?

[Ciebiada]

Hi. What's the status on this? :)

[theol0403]

If you're asking me, this PR is pending review and is ready for merge! I think the devs are just busy and havent gotten around to merging PRs yet.

Note to devs that my ability to make changes will drastically reduce come september (same goes for all my PRs), so review by then would be ideal.

[Sixzero]

Guys, can we merge this? What is the status on this?

[caksoylar]

Docs-wise it looks good, added a few suggestions to improve.

[sommerper]

Hey! What's the status on this? Can it be merged? I've been using this for a long time without problems now.

[akira-toriyama]

I am looking forward.

[Sixzero]

I am also using it for pretty long time... maybe already a year? I guess now there are conflicts which must be resolved, but who has write access?

[theol0403]

Conflicts are easy to fix. Just some documentation formatting.

[theol0403]

Bump - this is a well-requested feature!

[akira-toriyama]

👀

[petejohanson]

Thanks for your patience on this. Code looks good, tests to cover things, etc.

Please see my one style comment, and can you please rebase to fix the conflict file in the docs?

Thanks!

[theol0403]

Rebased and fixed!

[omichalek]

I am looking forward to this, it should make using the hold key (like ctrl) usable in combination with mouse clicks

[petejohanson]

Thanks!