Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boards): Fix build warnings for Corne-ish Zen builds #2150

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

caksoylar
Copy link
Contributor

Fixes warnings for two separate issues:

  • Missed include for battery header in display widget, after the change in 6f8d080 (similar to f71458a that fixed it for nice!view)
    • Removed no-longer-used BAS header includes
      • Some other files (nice_view and stock battery widget) have these as well, but I can't test a build for these. If just making sure they build OK is fine I can add a commit for these too
  • Disabled ZMK_USB in peripherals (didn't cause a build failure because it was forced off by its dependencies)

@petejohanson
Copy link
Contributor

@caksoylar Mind including the header removal for the others? As long as it still builds (which it should), that should be fine.

@caksoylar
Copy link
Contributor Author

Sure, will push it when I am home in the evening.

@caksoylar caksoylar requested a review from a team as a code owner February 6, 2024 05:08
@caksoylar
Copy link
Contributor Author

Pushed those too now, corne_left and right builds with OLED or nice!views seem to build OK here.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit b8846cf into zmkfirmware:main Feb 6, 2024
49 checks passed
@caksoylar caksoylar deleted the fix-zen-warnings branch February 6, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants