update og background image #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync dev to main
Sync dev to main
Sync dev to main
Sync dev to main
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
The commit history looks a bit off, shouldn't only eb277b2 show up in the PR? 🤔 |
CaliCastle
requested changes
Mar 8, 2025
Member
CaliCastle
left a comment
CaliCastle
left a comment
There was a problem hiding this comment.
I see that you've only changed public/assets/og-bg-zh-CN.jpg to the new one, I think we'd want public/assets/og-bg-en.jpg changed as well.
We could just place one public/assets/og-bg.jpg file and refactor since the background image is no longer locale sensitive.
Other changes are good 👍🏼
Member
|
Oh and there's a conflict on the PR as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update og background image and font