Skip to content

small bugfix to clean terminated node #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

small bugfix to clean terminated node #38

wants to merge 1 commit into from

Conversation

munger1985
Copy link
Contributor

@munger1985 munger1985 commented Jul 23, 2025 •
edited
Loading

small bugfix to clean terminated node #37

small fix to clean killed node,

@munger1985
Copy link
Contributor Author

now the
image
it will remove the node that has been already terminated

wy0824
wy0824 reviewed Jul 23, 2025
View reviewed changes
@munger1985
Copy link
Contributor Author

2 commits not allowed in one PR?

munger1985
munger1985 commented Jul 25, 2025
View reviewed changes
Copy link
Contributor Author

@munger1985 munger1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no , it is a ptr, should have a nil check

@munger1985
Copy link
Contributor Author

now this time , it is the best, i have used ai to enhance the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy0824 wy0824 wy0824 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@munger1985 @wy0824