Support py 3.12 opcodes: part 2 #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrax
reviewed
Jul 1, 2025
ASTree.cpp
Outdated
| { | ||
| stack.pop(); | ||
|
|
||
| if ((opcode == Pyc::END_FOR) && (mod->majorVer() == 3) && (mod->minorVer() == 12)) { |
There was a problem hiding this comment.
Is this not needed for 3.13 and later?
There was a problem hiding this comment.
Yes it seems to be changed in 3.13, but not sure when.
- 3.13 documentation says one pop
- 3.12 documentation says two pops
|
@zrax requesting to wait for draft PR to be moved to normal PR before reviewing. Helps avoid back and forth as well. |
whoami730
changed the title
|
Unable to find any code to generate |
|
Once part 1 and part 2 are reviewed, I will raise couple of more PRs. |
zrax
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COPY,BINARY_SLICEandSTORE_SLICEopcodes for Python 3.12BINARY_SLICEandSTORE_SLICEopcodes, unable to find useful test forCOPYopcode