Open
Conversation
whoami730
force-pushed
the
update-project
branch
2 times, most recently
from
b8ef7d5 to
ec1086b
Compare
whoami730
force-pushed
the
update-project
branch
from
ec1086b to
3a1498b
Compare
whoami730
commented
Sep 12, 2025
| @@ -0,0 +1,34 @@ | |||
| BasedOnStyle: LLVM | |||
Contributor
Author
There was a problem hiding this comment.
Formatting largely follows our existing codebase but can be altered as per needs.
| ) | ||
|
|
||
| # Enable/disable targets/tools | ||
| option(ENABLE_CLANG_FORMAT "Provide `format` and `format-check` targets using clang-format" ON) |
Contributor
Author
There was a problem hiding this comment.
Not tested if these tools are missing.
Contributor
Author
|
@zrax @greenozon Can we please have a review of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings linter and formatter support to
pycdc. It has been tried to avoid large code changes as much as possible, however, due to inconsistent formatting, some modifications need to be performed.Tools used are
clang-formatandclang-tidyrespectively. It is expected that both of these tools exist on the platform.Changes are primarily in 3 files -
CMakeLists.txt.clang-format.clang-tidyRemaining changes are either formatting or linting fixes.