Play pending audio frames in fenster_audio.h instead of stopping playback immediately
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will resolve audio cutting off after a program using `fenster_audio.h` finishes it's execution - a very simple fix that greatly simplifies usage of the `fenster_audio.h` library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve audio cutting off after a program using
fenster_audio.hfinishes it's execution - a very simple fix that will greatly simplify the usage of thefenster_audio.hlibrary.I implemented this only for the Linux and Win32 version in this PR, because as far as I know the macOS version already worked this way, since
inImmediateis set tofalsewhen callingAudioQueueStop(AudioQueueRef inAQ, Boolean inImmediate)at https://github.com/jonasgeiler/fenster/blob/1393ff82958532e3f8c5dfdf5b131c065cb513e7/fenster_audio.h#L78