install: Migrate from setup.py to pyproject.toml.#875
Conversation
| name="zulip", | ||
| version=version(), | ||
| description="Bindings for the Zulip message API", | ||
| long_description=long_description, |
There was a problem hiding this comment.
This is superseded by readme = "README.md" in the pyproject.toml version. I checked the resulting METADATA file in the package info, and it showed the entire README.md in it.
| Source = "https://github.com/zulip/python-zulip-api/" | ||
| Documentation = "https://zulip.com/api" | ||
|
|
||
| [project.scripts] |
There was a problem hiding this comment.
I confirmed that the scripts all exist in the installed virtualenv bin directory.
| zulip-api = "zulip.cli:cli" | ||
|
|
||
| [tool.hatch.version] | ||
| path = "zulip/__init__.py" |
There was a problem hiding this comment.
The version is correctly extracted as 0.9.0.
|
Did you consider uv instead of Setuptools or Hatch? You only migrated zulip, but we publish zulip-bots and zulip-botserver in sync with zulip, so we should migrate all three packages at once, perhaps using uv workspaces (it looks like Hatch is still missing an equivalent feature: pypa/hatch#233). |
|
I wasn't aware of |
|
I just tried |
|
Heads up @rht, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
support recursive file includes.
Fixes: N/A
How did you test this PR?
pytest tests(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: