Retention of scroll offset in emoji #1269

AshutoshKhadse23 · 2025-01-09T09:44:48Z

The issue regarding retention of scroll offset in emoji is solve
Resolving issue #1175

issue.1175.mp4

AshutoshKhadse23 · 2025-01-09T09:58:51Z

Hello @chrisbobbe ,
Now it have only changes made to solve the issue ,you can review it.

chrisbobbe

Thanks! Small comments from a quick review; also, please change the commit message to match the project style.

lib/widgets/autocomplete.dart

gnprice · 2025-02-06T05:21:37Z

Thanks @AshutoshKhadse23 for picking this up!

We're now focusing more strictly on launch issues until the app's launch is ready, and this is a post-launch issue.

I'll leave this PR as an exception where we'll proceed with it anyway, because it looks like it may be possible for the fix to be quite small.

The next step will be for you to revise it to address each of @chrisbobbe's comments above. Then we can give it a new round of review.

Because we're prioritizing launch issues, this PR may wait longer for review than others. If you're interested in contributing to Zulip, I recommend taking a look also at open issues in the upcoming milestones up through M5 Launch.

gnprice · 2025-03-14T23:25:39Z

Cross-linking because I happened across it while scanning through PRs during triage: it looks like a previous iteration of this PR was

Retention of scroll offset in emoji #1206.

@AshutoshKhadse23 as a reminder of comments you received earlier at #1232 (comment) and #1232 (comment): when revising a PR, please update the existing PR rather than sending a new one.

(In any case, for this PR the next step is for you to revise it as described above.)

AshutoshKhadse23 · 2025-04-01T04:17:51Z

Hello @chrisbobbe,
Now it ready for review and I had revised my code to remove the confusion of .toString

gnprice · 2025-05-10T01:13:10Z

Before we can review this, it will need to meet the two basic requirements described in our README:
https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

It needs tests, and it needs to be organized in clear and coherent commits.

AshutoshKhadse23 · 2026-01-14T03:59:50Z

@gnprice @chrisbobbe Sorry for the delay, but now it is ready for review.

gnprice · 2026-01-15T00:27:20Z

OK, this looks ready for review, thanks.

@AshutoshKhadse23 I see you have several other PRs open too: #2058, #2073, #2075. Please stick to just one issue until your first PR is merged. See the contributing guide:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#claiming-an-issue

So please pick one of these four PRs to continue with, and close the other three for now. You can always reopen them later if the corresponding issues are still open.

AshutoshKhadse23 · 2026-01-15T04:19:31Z

@gnprice @chrisbobbe,
I think this PR will not take much time to merge, according to me.
So, could you start reviewing this PR? Until then, I will convert the other PR into drafts

chrisbobbe

The commit message refers to #1121, which is the wrong issue. That's confusing; please fix that.

See also one comment below.

test/widgets/autocomplete_test.dart

chrisbobbe · 2026-01-15T21:14:05Z

Until then, I will convert the other PR into drafts

Also: I see you have not done this; please do it.

AshutoshKhadse23 · 2026-01-16T07:50:49Z

Until then, I will convert the other PR into drafts

Also: I see you have not done this; please do it.

I did this

AshutoshKhadse23 · 2026-01-23T07:56:42Z

@chrisbobbe Could you review it now?

chrisbobbe

Thanks! Comments below about the test.

test/widgets/autocomplete_test.dart

chrisbobbe · 2026-01-26T18:37:02Z

test/widgets/autocomplete_test.dart

+      // Find the autocomplete ListView's Scrollable.
+      final listViewFinder = find.descendant(
+        of: find.byType(Material),
+        matching: find.byType(ListView),
+      );
+      final scrollableFinder = find.descendant(
+        of: listViewFinder,
+        matching: find.byType(Scrollable));
+
+      // Scroll until the last item is visible.
+      await tester.scrollUntilVisible(find.text('sz_last_item'), 50,
+        scrollable: scrollableFinder);
+      await tester.pump();


Do we really need to pass a value for the optional scrollable: in the tester.scrollUntilVisible call? What happens if we don't?

Yes, by thinking deeply, I understoodthat this is the thing that is not required, so remove the optional scrollable: parameter

test/widgets/autocomplete_test.dart

AshutoshKhadse23 · 2026-01-27T03:52:21Z

test/widgets/autocomplete_test.dart

+
+      // Verify the first item is visible and the last is not (needs scrolling).
+      check(find.text('sa_first_item')).findsOne();
+      check(find.text('sz_last_item')).findsNothing();


The "last is not" part isn't implemented, it looks like.

Added check that the last item is not visible initially

AshutoshKhadse23 · 2026-01-27T03:56:50Z

test/widgets/autocomplete_test.dart

+      check(find.text('sz_last_item')).findsOne();
+      // The first item should no longer be visible.
+      check(find.text('sa_first_item')).findsNothing();
+


We should also check that the first item is not visible here.

Added check that the first item is not visible after scrolling to the bottom

When searching for an emoji (or other autocomplete items), scrolling through results, and then modifying the query, the autocomplete list would retain its scrolled position while showing new results. This created confusing UX where results appeared cut off at the top. Fix this by adding a ScrollController to the autocomplete ListView and resetting the scroll position to the top whenever the query content changes. Fixes: zulip#1175

chrisbobbe reviewed Jan 22, 2025

View reviewed changes

lib/widgets/autocomplete.dart Outdated Show resolved Hide resolved

gnprice added this to the M6: Post-launch milestone Feb 6, 2025

gnprice added the maintainer review PR ready for review by Zulip maintainers label Feb 6, 2025

AshutoshKhadse23 requested a review from chrisbobbe May 5, 2025 04:19

gnprice removed the request for review from chrisbobbe May 10, 2025 01:13

AshutoshKhadse23 force-pushed the retention-scroll-cleaned branch from 77bb431 to bad7df0 Compare January 14, 2026 03:46

AshutoshKhadse23 requested a review from chrisbobbe January 14, 2026 03:59

AshutoshKhadse23 force-pushed the retention-scroll-cleaned branch from bad7df0 to bf35b81 Compare January 14, 2026 14:06

chrisbobbe reviewed Jan 15, 2026

View reviewed changes

test/widgets/autocomplete_test.dart Outdated Show resolved Hide resolved

AshutoshKhadse23 force-pushed the retention-scroll-cleaned branch 3 times, most recently from 8ff046b to 1f2e2b7 Compare January 16, 2026 07:49

AshutoshKhadse23 requested a review from chrisbobbe January 16, 2026 13:41

AshutoshKhadse23 force-pushed the retention-scroll-cleaned branch 2 times, most recently from 1f2e2b7 to 2854428 Compare January 23, 2026 07:54

AshutoshKhadse23 mentioned this pull request Jan 24, 2026

status: Add status end time functionality (#1944) #2080

Draft

chrisbobbe reviewed Jan 26, 2026

View reviewed changes

AshutoshKhadse23 force-pushed the retention-scroll-cleaned branch from 2854428 to 4b866c5 Compare January 27, 2026 03:48

AshutoshKhadse23 commented Jan 27, 2026

View reviewed changes

AshutoshKhadse23 requested a review from chrisbobbe January 27, 2026 03:58

AshutoshKhadse23 force-pushed the retention-scroll-cleaned branch from 4b866c5 to a85ea60 Compare January 27, 2026 04:26

AshutoshKhadse23 force-pushed the retention-scroll-cleaned branch from a85ea60 to 2c33d19 Compare January 27, 2026 10:39

Retention of scroll offset in emoji #1269

Are you sure you want to change the base?

Retention of scroll offset in emoji #1269

Uh oh!

Conversation

AshutoshKhadse23 commented Jan 9, 2025

Uh oh!

AshutoshKhadse23 commented Jan 9, 2025

Uh oh!

chrisbobbe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gnprice commented Feb 6, 2025

Uh oh!

gnprice commented Mar 14, 2025

Uh oh!

AshutoshKhadse23 commented Apr 1, 2025

Uh oh!

gnprice commented May 10, 2025

Uh oh!

AshutoshKhadse23 commented Jan 14, 2026

Uh oh!

gnprice commented Jan 15, 2026

Uh oh!

AshutoshKhadse23 commented Jan 15, 2026

Uh oh!

chrisbobbe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrisbobbe commented Jan 15, 2026

Uh oh!

AshutoshKhadse23 commented Jan 16, 2026

Uh oh!

AshutoshKhadse23 commented Jan 23, 2026

Uh oh!

chrisbobbe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrisbobbe Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

AshutoshKhadse23 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AshutoshKhadse23 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

AshutoshKhadse23 Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AshutoshKhadse23 Jan 27, 2026 •

edited

Loading