home: Center align the "try another account" message in loading placeholder #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
reviewed
Feb 5, 2025
KYash03
force-pushed
the
center-align-tryAnotherAccountMessage
branch
from
402d967 to
7659479
Compare
|
Hi @chrisbobbe, I've made the changes. Please review. Apologies for the earlier confusion with closing and reopening the PR! |
|
Bump on #1326 (comment) ; please pay attention to spacing/linebreaks/indentation. |
KYash03
force-pushed
the
center-align-tryAnotherAccountMessage
branch
from
f217e16 to
dc49661
Compare
KYash03
commented
Feb 6, 2025
lib/widgets/home.dart
Outdated
Comment on lines
215
to
217
| Text(textAlign: TextAlign.center, | ||
| zulipLocalizations.tryAnotherAccountMessage(account.realmUrl.toString()), | ||
| ), |
There was a problem hiding this comment.
Is this what you're expecting, @chrisbobbe?
There was a problem hiding this comment.
Text(textAlign: TextAlign.center,
zulipLocalizations.tryAnotherAccountMessage(account.realmUrl.toString())),as I said in #1326 (comment)
There was a problem hiding this comment.
Fixed now. Sorry for the confusion earlier, GitHub's formatting made it hard to see exactly what was expected.
KYash03
force-pushed
the
center-align-tryAnotherAccountMessage
branch
from
dc49661 to
21e496b
Compare
|
Thanks @KYash03 for working on this and Chris for the previous reivews! This looks good to me. |
PIG208
added
integration review
|
Thanks for taking care of this! Looks good; merging, with one small fix: (Note the punctuation in Chris's comment #1326 (comment) above.) |
gnprice
force-pushed
the
center-align-tryAnotherAccountMessage
branch
from
21e496b to
4f438d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1246.
Screenshot