msglist: Update icon of "Mark all messages as read" button #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utton at the bottom of the message list The icon is taken from Zulip web: https://github.com/zulip/zulip/blob/74d7f11923986db0b017f5d6054abafd21adb6e3/web/shared/icons/mark-as-read.svg
tomlin7
changed the title
…t the bottom of the message list
tomlin7
force-pushed
the
mark-all-read-icon
branch
from
491959e to
b05f96d
Compare
|
@lakshya1goel I just noticed the additional changes in your pr, but the pr is dated older than this issue, though -- might be the reason i missed it. @chrisbobbe thoughts? |
|
The issue was filed after the PR #1274, but it described a change that PR was already making 🙂 and the PR was updated the same day to say it fixed the issue. When picking up an issue it's always a good idea to look at existing PRs that are linked in the issue sidebar: Thanks @tomlin7 for contributing to Zulip; I hope you'll look around and find another next issue to try (in addition to revising existing PRs for code-review feedback). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1357
Changes
Screenshots