Skip to content

Conversation

@shkshreyas
Copy link

@shkshreyas shkshreyas commented Feb 22, 2025

Before
image

After
image

@gnprice
Copy link
Member

gnprice commented Feb 24, 2025

Before we can review a PR, it needs to have tests, and it needs to have clear and coherent commits free of unrelated changes. See our README, which also links to resources with more details.

Before asking other people to spend time reviewing your work, you should also take time to review it yourself:
https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#reviewing-your-own-code
In addition to the problems mentioned above, this PR has an unused duplicate copy of its code in another file, complete with a comment that looks like it's something an LLM wrote for you to read — not something that makes sense in the context of a PR:

// Example usage in a widget
Widget buildOrderedList(List<String> items) {

And the "After" screenshot shows the two-digit numbers very far out of alignment with the one-digit numbers. Both of those are things you definitely should have been able to catch for yourself.

In this case, there's already a PR #1329 which fixes this issue #1356 and is near merge. So there's no need for another PR for this, and I'm closing this one.

@gnprice gnprice closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants