Upgrade Flutter, packages and Android build dependencies #1474

rajveermalviya · 2025-04-16T00:28:32Z

No description provided.

gnprice · 2025-04-16T16:56:20Z

ios/Podfile.lock

-  app_settings: 58017cd26b604ae98c3e65acbdd8ba173703cc82
-  device_info_plus: bf2e3232933866d73fe290f2942f2156cdd10342
+  app_settings: 5127ae0678de1dcc19f2293271c51d37c89428b2
+  device_info_plus: 21fcca2080fbcd348be798aa36c3e5ed849eefbe


These Podfile.lock changes appear to revert the changes made in 16e4d88. That's puzzling.

This commit was result of running tools/upgrade flutter-local and then running the app on both iOS and macOS.

I tried flutter run after flutter clean on this commit again, to make sure there is nothing wrong with build cache, but it still ends up making these changes.

What happens if you run the app before this commit (and with Flutter at the previous version)? If that makes the same change, then that change should happen in its own commit.

These are third-party packages, not dependencies of Flutter, so it'd be surprising if the versions we get for them in CocoaPods are affected by the Flutter version.

It'd also be good to sort out what the difference is between the versions before and after this change. Is device_info_plus of 21fcca2080fbcd348be798aa36c3e5ed849eefbe a newer or older version than bf2e3232933866d73fe290f2942f2156cdd10342?

It looks like the current pattern may be that when you run the app on your machine, you get the version from after this change (which is also the version from before 16e4d88), but when Chris runs the app on his machine he gets the version that's currently in main. We'd like to instead get to a recipe that everyone can run (maybe running pod repo update and then running the app?) that reproduces the same results on each machine, and for those results to represent an up-to-date version of each dependency.

Added a separate base commit that introduces these Podfile.lock changes.

Cool.

The commit message should mention the fact that it's reverting a previous commit — that's quite relevant information for understanding what we're thinking with this change.

gnprice

Thanks @rajveermalviya for taking care of this! I've now read through all the changes. A few comments below (plus the subthread above).

gnprice · 2025-04-17T01:30:17Z

pubspec.yaml

-  file_picker: ^9.0.2
+  file_picker: ^10.1.2


Changelog: https://pub.dev/packages/file_picker/changelog#1012 There's one breaking change for an option we didn't use, and some bug fixes.

So the changelog says:

BREAKING CHANGE: The compressionQuality property in the pickFiles method now defaults to 0.
BREAKING CHANGE: The allowCompression property has been deprecated in favor of compressionQuality, and now defaults to false.

We don't use either allowCompression or compressionQuality. I'm not sure what the meaning of compressionQuality 0 is, though — that's a change to the default, so the fact that we don't pass the option means we are affected.

Would you confirm what that value means?

Right, the docs don't say much, but looking at the implementation:

On Android it will manually compress any image picked by the file picker, if compressionQuality > 0, then provide the compressed result.

On iOS, it will set presets for image and video files if compressionQuality is non-zero, but ignoring the actual compressionQuality value, where the OS will do the compression instead of plugin doing it manually.

Previously, the defaults were allowCompression = true and compressionQuality = 30. I doubt we needed that, so I guess this breaking change is for the better.

Great. OK, so the net effect is:

It used to compress the images.

Now it doesn't.

Looks like the PR that made the change is this: miguelpruivo/flutter_file_picker#1744

And it was described as fixing two issues, which are both about how the manual compression it did on Android caused problems.

The iOS implementation looks like it should work nice and smoothly, though, so that there it comes down to a product question of whether we want the images (and videos) compressed. Compressing uploaded images is a feature request we've gotten a few times, and considered on our own before that:
#1419
zulip/zulip-mobile#4340 (comment)
zulip/zulip-mobile#3499
zulip/zulip-mobile#2749

(That latest issue was filed in this repo, but I now suspect it's about zulip-mobile — it says "The current zulip android client" and doesn't give any indication of being aware of the distinction.)

Anyway, let's go ahead with the upgrade and take the new defaults. We'll see if we get feedback one way or another. We'll revise this commit message to be clear about the change, though.

(And as Chris pointed out below, we have #855 to move off that library — then we'll get whatever behavior upstream's package:image_picker offers.)

gnprice · 2025-04-17T01:32:11Z

android/app/lint-baseline.xml

+    <issue
+        id="InvalidPackage"
+        message="Invalid package reference in library; not included in Android: `javax.xml.stream`. Referenced from `org.apache.tika.utils.XMLReaderUtils`.">
+        <location
+            file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.apache.tika/tika-core/3.1.0/6ba44a9ddf8f6f2b4bc88e8bc64269aea0424607/tika-core-3.1.0.jar"/>


Additionally, add a suppression of a lint error caused by a dependency of this package [i.e., file_picker].

I see, annoying.

Seems like the impact of this, if there is one, would be that it crashes when trying to read some XML file. Is there a file_picker upstream issue for this? If we're lucky, someone has already investigated and has a convincing reason it won't matter for our use (or perhaps even for file_picker's use in general).

I think you said in today's call that you looked in the package's tracker and didn't find an issue for this.

That's fine and we can leave it there — this probably doesn't affect our app's behavior, and we're planning to switch off this library in the future anyway. The commit message should just mention that, though: the fact that you looked and didn't find an upstream issue.

gnprice · 2025-04-17T01:37:33Z

pubspec.lock

      url: "https://pub.dev"
    source: hosted
-    version: "2.21.1"
+    version: "2.22.0"
  firebase_messaging:


This commit is result of following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core pod update --project-directory=ios/ pod update --project-directory=macos/ Changelogs: https://pub.dev/packages/firebase_core/changelog#3130 https://pub.dev/packages/firebase_messaging/changelog#1525 Notable changes include bump to Firebase Android BoM (33.9.0 to 33.11.0) and Firebase iOS SDK (11.8.0 to 11.10.0), changelog for those are at: https://firebase.google.com/support/release-notes/android https://firebase.google.com/support/release-notes/ios One bug fix on Android: https://firebase.google.com/support/release-notes/android#messaging_v24-1-1 And one migration on iOS to use a newer API: https://github.com/firebase/firebase-ios-sdk/pull/14457

Thanks for tracking all these down!

gnprice · 2025-04-17T01:40:19Z

test/widgets/colors_checks.dart

-extension ColorSwatchChecks<T> on Subject<ColorSwatch<T>> {
-  /// package:checks-style wrapper for [flutter_matcher.isSameColorSwatchAs].
-  void isSameColorSwatchAs(ColorSwatch<T> colorSwatch) {


Additionally, use the newly available check for `isSameColorSwatchAs`, replacing the local copy.

🎉

gnprice · 2025-04-17T01:42:58Z

android/app/lint-baseline.xml

+    <issue
+        id="SyntheticAccessor"
+        message="Access to `private` method `deepEqualsNotifications` of class `Notifications_gKt` requires synthetic accessor"
+        errorLine1="    return deepEqualsNotifications(toList(), other.toList())  }"
+        errorLine2="           ~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/zulip/flutter/Notifications.g.kt"


Hmm. Is there an upstream issue in Pigeon tracking this?

Since there's a lot of copies of this, it seems likely that they'd churn frequently when we make changes to our pigeons and/or when unrelated Pigeon upgrades cause the line numbers to change.

So it'd be good to express this lint-ignore in a way that's more stable. Can we say e.g. that this lint rule should be ignored for this file? (Perhaps Pigeon should be emitting such a suppression in the generated file?)

Well, turns out this just got fixed in flutter/packages#9034. Updated past that now.

chrisbobbe · 2025-04-17T05:50:57Z

(I see a few comments about file_picker; here's a small reminder that #855 is for moving off of that. 🙂)

Changelog: https://pub.dev/packages/[file_picker/changelog#1012](https://github.com/file_picker/changelog/issues/1012) There are two breaking changes, one about deprecating an option `allowCompression` and changing the default to false (was true), and another about changing default for `compressionQuality` to 0 (was 30). This means previously it used to compress media by default and now it doesn't. See discussion for why we take in the new defaults: zulip#1474 (comment) Additionally, add a suppression of a lint error caused by a dependency of package:file_picker.

rajveermalviya · 2025-04-17T21:57:08Z

Thanks for the review @gnprice! PTAL.

gnprice

Thanks for the revision!

These changes all look good. Just a couple more things to mention in the commit messages at this point.

gnprice · 2025-04-18T05:27:34Z

ios/Podfile.lock

-  app_settings: 58017cd26b604ae98c3e65acbdd8ba173703cc82
-  device_info_plus: bf2e3232933866d73fe290f2942f2156cdd10342
+  app_settings: 5127ae0678de1dcc19f2293271c51d37c89428b2
+  device_info_plus: 21fcca2080fbcd348be798aa36c3e5ed849eefbe


Cool.

The commit message should mention the fact that it's reverting a previous commit — that's quite relevant information for understanding what we're thinking with this change.

gnprice · 2025-04-18T05:28:42Z

pubspec.yaml

-  file_picker: ^9.0.2
+  file_picker: ^10.1.2


Changelog: https://pub.dev/packages/[file_picker/changelog#1012](https://github.com/file_picker/changelog/issues/1012)

This link seems to have gotten corrupted 🙂

gnprice · 2025-04-18T05:31:11Z

android/app/lint-baseline.xml

+    <issue
+        id="InvalidPackage"
+        message="Invalid package reference in library; not included in Android: `javax.xml.stream`. Referenced from `org.apache.tika.utils.XMLReaderUtils`.">
+        <location
+            file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.apache.tika/tika-core/3.1.0/6ba44a9ddf8f6f2b4bc88e8bc64269aea0424607/tika-core-3.1.0.jar"/>


I think you said in today's call that you looked in the package's tracker and didn't find an issue for this.

That's fine and we can leave it there — this probably doesn't affect our app's behavior, and we're planning to switch off this library in the future anyway. The commit message should just mention that, though: the fact that you looked and didn't find an upstream issue.

Changelog: https://pub.dev/packages/file_picker/changelog#1012 There are two breaking changes, one about deprecating an option `allowCompression` and changing the default to false (was true), and another about changing default for `compressionQuality` to 0 (was 30). This means previously it used to compress media by default and now it doesn't. See discussion for why we take in the new defaults: zulip#1474 (comment) There is also a lint error that is caused by a dependency of package:file_picker. I didn't find any reports about it upstream, and we probably aren't affected by it (confirmed by running simple upload tests of a PDF, an XML file and an image, and didn't see any errors/crashes), so for now added a suppression for that error. Also we're planning to switch away from this library anyway (zulip#855).

rajveermalviya · 2025-04-18T15:32:47Z

Thanks for the review @gnprice! Pushed an update, PTAL.

gnprice · 2025-04-18T19:33:25Z

Thanks for the revision! All looks good now — merging.

This reverts 16e4d88. These are made automatically when running `flutter run`, probably because of the updated Ruby version on my machine, than what Chris had when he authored that commit. See discussion: https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/Podfile.2Elock.20clash.20.23F92/near/2156970

Changelog: https://pub.dev/packages/app_settings/changelog#611

Changelog: https://pub.dev/packages/file_picker/changelog#1012 There are two breaking changes, one about deprecating an option `allowCompression` and changing the default to false (was true), and another about changing default for `compressionQuality` to 0 (was 30). This means previously it used to compress media by default and now it doesn't. See discussion for why we take in the new defaults: zulip#1474 (comment) There is also a lint error that is caused by a dependency of package:file_picker. I didn't find any reports about it upstream, and we probably aren't affected by it (confirmed by running simple upload tests of a PDF, an XML file and an image, and didn't see any errors/crashes), so for now added a suppression for that error. Also we're planning to switch away from this library anyway (zulip#855).

This commit is result of following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core pod update --project-directory=ios/ pod update --project-directory=macos/ Changelogs: https://pub.dev/packages/firebase_core/changelog#3130 https://pub.dev/packages/firebase_messaging/changelog#1525 Notable changes include bump to Firebase Android BoM (33.9.0 to 33.11.0) and Firebase iOS SDK (11.8.0 to 11.10.0), changelog for those are at: https://firebase.google.com/support/release-notes/android https://firebase.google.com/support/release-notes/ios One bug fix on Android: https://firebase.google.com/support/release-notes/android#messaging_v24-1-1 And one migration on iOS to use a newer API: firebase/firebase-ios-sdk#14457

Changelog: https://pub.dev/packages/flutter_checks/changelog#012---2025-04-11 Additionally, use the newly available check for `isSameColorSwatchAs`, replacing the local copy.

Changelog: https://pub.dev/packages/pigeon/changelog#2531 Updates to the generator to generate equality methods for the classes, and some bug fixes.

Changelogs: https://docs.gradle.org/8.10/release-notes.html https://docs.gradle.org/8.11/release-notes.html https://docs.gradle.org/8.12/release-notes.html https://docs.gradle.org/8.13/release-notes.html Some highlights: * 8.10 "Configuration cache improvements" * 8.11 More "Configuration Cache improvements" - Specifically, the new flag `org.gradle.configuration-cache.parallel=true` * 8.12 "Error and warning reporting improvements" * 8.13 "Toolchain support"

Release notes: https://kotlinlang.org/docs/whatsnew2020.html https://kotlinlang.org/docs/whatsnew21.html https://kotlinlang.org/docs/whatsnew2120.html Highlights: * 2.0.20 - Standard library; Support for UUIDs. - Otherwise mostly related to Wasm, Native and Kotlin Multiplatform. * 2.1.0 - K2; Extra compiler checks. - Otherwise mostly related to Wasm, Native and Kotlin Multiplatform. * 2.1.20 - Mostly new experimental features.

Release notes: https://developer.android.com/build/releases/past-releases/agp-8-6-0-release-notes https://developer.android.com/build/releases/past-releases/agp-8-7-0-release-notes https://developer.android.com/build/releases/past-releases/agp-8-8-0-release-notes https://developer.android.com/build/releases/gradle-plugin (for 8.9, for now) Changes mostly seem to be bug fixes to various components. One notable change is that AGP version 8.9 now requires Android Studio Meerkat (2024.3.1 Patch 1). Additionally, use the new extension `toUri` to make the linter happy.

gnprice reviewed Apr 16, 2025

View reviewed changes

gnprice self-assigned this Apr 17, 2025

gnprice added the integration review Added by maintainers when PR may be ready for integration label Apr 17, 2025

gnprice reviewed Apr 17, 2025

View reviewed changes

rajveermalviya force-pushed the upgrade-flutter branch from c7a40ae to 2e7e795 Compare April 17, 2025 16:10

rajveermalviya force-pushed the upgrade-flutter branch 2 times, most recently from f71a341 to f86ed2e Compare April 17, 2025 21:45

rajveermalviya requested a review from gnprice April 17, 2025 21:57

gnprice reviewed Apr 18, 2025

View reviewed changes

rajveermalviya force-pushed the upgrade-flutter branch from f86ed2e to 5fca3fa Compare April 18, 2025 15:31

rajveermalviya requested a review from gnprice April 18, 2025 15:32

rajveermalviya added 11 commits April 18, 2025 12:33

deps: Upgrade Flutter to 3.32.0-1.0.pre.87

24c3807

deps: Update app_settings to 6.1.1, from 5.2.0

6d2a102

Changelog: https://pub.dev/packages/app_settings/changelog#611

deps: Update flutter_checks to 0.1.2, from 0.1.1

830b94d

Changelog: https://pub.dev/packages/flutter_checks/changelog#012---2025-04-11 Additionally, use the newly available check for `isSameColorSwatchAs`, replacing the local copy.

deps: Update pigeon to 25.3.1, from 25.0.0

feedc06

Changelog: https://pub.dev/packages/pigeon/changelog#2531 Updates to the generator to generate equality methods for the classes, and some bug fixes.

deps: Upgrade packages within constraints (tools/upgrade pub)

9d92cca

gnprice force-pushed the upgrade-flutter branch from 5fca3fa to b431d8d Compare April 18, 2025 19:33

gnprice merged commit b431d8d into zulip:main Apr 18, 2025

rajveermalviya deleted the upgrade-flutter branch May 5, 2025 16:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Flutter, packages and Android build dependencies #1474

Upgrade Flutter, packages and Android build dependencies #1474

rajveermalviya commented Apr 16, 2025

gnprice Apr 16, 2025

rajveermalviya Apr 16, 2025

gnprice Apr 17, 2025

rajveermalviya Apr 17, 2025

gnprice Apr 18, 2025

gnprice left a comment

gnprice Apr 17, 2025

rajveermalviya Apr 17, 2025

gnprice Apr 17, 2025

gnprice Apr 17, 2025

gnprice Apr 17, 2025

gnprice Apr 18, 2025

gnprice Apr 17, 2025

gnprice Apr 17, 2025

gnprice Apr 17, 2025

gnprice Apr 17, 2025

rajveermalviya Apr 17, 2025

chrisbobbe commented Apr 17, 2025

rajveermalviya commented Apr 17, 2025

gnprice left a comment

gnprice Apr 18, 2025

gnprice Apr 18, 2025

gnprice Apr 18, 2025

rajveermalviya commented Apr 18, 2025

gnprice commented Apr 18, 2025

Upgrade Flutter, packages and Android build dependencies #1474

Upgrade Flutter, packages and Android build dependencies #1474

Conversation

rajveermalviya commented Apr 16, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnprice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisbobbe commented Apr 17, 2025

rajveermalviya commented Apr 17, 2025

gnprice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rajveermalviya commented Apr 18, 2025

gnprice commented Apr 18, 2025