emoji: Generate popular candidates using names from server data#1506

Merged

gnprice merged 14 commits intozulip:mainfrom

chrisbobbe:pr-fix-smile-emoji-button

May 21, 2025

Commits on May 21, 2025

emoji [nfc]: Move list of popular emoji codes to its own static field

chrisbobbe
authored and
gnprice
committed
emoji [nfc]: Read _popularCandidates only through public getter

chrisbobbe
authored and
gnprice
committed
emoji [nfc]: Make popularEmojiCandidates non-static

chrisbobbe
authored and
gnprice
committed
emoji [nfc]: Make popularEmojiCandidates a method, not getter

chrisbobbe
authored and
gnprice
committed
emoji [nfc]: Move popularEmojiCandidates implementation down out of mixin

chrisbobbe
authored and
gnprice
committed
emoji test: Change one autocomplete test to use a non-popular emoji

chrisbobbe
authored and
gnprice
committed
test: Add eg.serverEmojiDataPopular for tests that would break without it

chrisbobbe
authored and
gnprice
committed
emoji [nfc]: Make a helper's helper not mutate lists of emoji names

chrisbobbe
authored and
gnprice
committed
emoji_reaction test: Do a store.setServerEmojiData earlier

chrisbobbe
authored and
gnprice
committed
emoji test [nfc]: Make a nested `prepare` more like another (1/2)

chrisbobbe
authored and
gnprice
committed
emoji test [nfc]: Make a nested `prepare` more like another (2/2)

chrisbobbe
authored and
gnprice
committed
emoji test [nfc]: Pull out `prepare` function for reuse

chrisbobbe
authored and
gnprice
committed
emoji: Generate popular candidates using names from server data

chrisbobbe
authored and
gnprice
committed
test: Change '1f642': 'smile' emoji to 'slight_smile' where it appears

chrisbobbe
authored and
gnprice
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

emoji: Generate popular candidates using names from server data#1506

emoji: Generate popular candidates using names from server data#1506
gnprice merged 14 commits intozulip:mainfrom
chrisbobbe:pr-fix-smile-emoji-button

Commits on May 21, 2025

emoji [nfc]: Move list of popular emoji codes to its own static field

emoji [nfc]: Read _popularCandidates only through public getter

emoji [nfc]: Make popularEmojiCandidates non-static

emoji [nfc]: Make popularEmojiCandidates a method, not getter

emoji [nfc]: Move popularEmojiCandidates implementation down out of mixin

emoji test: Change one autocomplete test to use a non-popular emoji

test: Add eg.serverEmojiDataPopular for tests that would break without it

emoji [nfc]: Make a helper's helper not mutate lists of emoji names

emoji_reaction test: Do a store.setServerEmojiData earlier

emoji test [nfc]: Make a nested `prepare` more like another (1/2)

emoji test [nfc]: Make a nested `prepare` more like another (2/2)

emoji test [nfc]: Pull out `prepare` function for reuse

emoji: Generate popular candidates using names from server data

test: Change '1f642': 'smile' emoji to 'slight_smile' where it appears