-
Notifications
You must be signed in to change notification settings - Fork 310
home: Add placeholder text for empty Inbox, Channels, and Direct messages #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Direct messages (when #127 is done, soon, there will be a "New DM" button at the bottom):
|
I'm pretty sure we had a CZO discussion about what to write as the second sentence in the empty inbox? |
Ah yeah, that's right: #mobile > iOS feedback for Julia community member @ 💬 So e.g.
(but with links instead of italics). Putting inline links (or italics, icons, etc.) in prose is blocked on getting it to work with internationalization (#1285), though. That version of a second sentence seems kind of useless without the links, so I think we should either leave it off or rewrite so that it calls attention to the nav buttons at the bottom. And file a follow-up issue for putting the links in there, noting that it's blocked on #1285. |
OK, we can do:
|
…ages The Figma has some graphics on all of these, but we'll leave that for later: see issue zulip#1551. Fixes: zulip#385 Fixes: zulip#386
f9c2d91
to
12cd62a
Compare
SGTM; updated (and updated the screenshots), and filed #1553 for the text with links. |
The "Direct messages" part of this was requested as part of #127 new-DM: it's item 0 in #1322 (comment) . This should block on the rest of #127, because the empty "Direct messages" placeholder says "Why not start the conversation?", and there's no way to do that pre-#127.
Screenshots coming soon.
cc @alya
The Figma has some graphics on all of these, but we'll leave that for later: see issue #1551.
Fixes: #385
Fixes: #386