Skip to content

home: Add placeholder text for empty Inbox, Channels, and Direct messages #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisbobbe
Copy link
Collaborator

@chrisbobbe chrisbobbe commented Jun 6, 2025

The "Direct messages" part of this was requested as part of #127 new-DM: it's item 0 in #1322 (comment) . This should block on the rest of #127, because the empty "Direct messages" placeholder says "Why not start the conversation?", and there's no way to do that pre-#127.

Screenshots coming soon.

cc @alya


The Figma has some graphics on all of these, but we'll leave that for later: see issue #1551.

Fixes: #385
Fixes: #386

@chrisbobbe
Copy link
Collaborator Author

chrisbobbe commented Jun 6, 2025

Inbox:

Before After
image image
image image

@chrisbobbe
Copy link
Collaborator Author

chrisbobbe commented Jun 6, 2025

Direct messages (when #127 is done, soon, there will be a "New DM" button at the bottom):

Before After
image image
image image

@chrisbobbe
Copy link
Collaborator Author

Channels:

Before After
image image
image image

@chrisbobbe chrisbobbe requested a review from gnprice June 6, 2025 01:22
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Jun 6, 2025
@chrisbobbe chrisbobbe added this to the M5a: Launch blockers milestone Jun 6, 2025
@alya
Copy link
Collaborator

alya commented Jun 6, 2025

I'm pretty sure we had a CZO discussion about what to write as the second sentence in the empty inbox?

@chrisbobbe
Copy link
Collaborator Author

Ah yeah, that's right: #mobile > iOS feedback for Julia community member @ 💬

So e.g.

There are no unread messages in your inbox. You might be interested in Combined feed or Channels.

(but with links instead of italics).

Putting inline links (or italics, icons, etc.) in prose is blocked on getting it to work with internationalization (#1285), though. That version of a second sentence seems kind of useless without the links, so I think we should either leave it off or rewrite so that it calls attention to the nav buttons at the bottom. And file a follow-up issue for putting the links in there, noting that it's blocked on #1285.

@alya
Copy link
Collaborator

alya commented Jun 6, 2025

OK, we can do:

There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.

…ages

The Figma has some graphics on all of these, but we'll leave that
for later: see issue zulip#1551.

Fixes: zulip#385
Fixes: zulip#386
@chrisbobbe
Copy link
Collaborator Author

SGTM; updated (and updated the screenshots), and filed #1553 for the text with links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InboxPage: Design / implement appearance when empty RecentDmConversationsPage: Design / implement appearance when empty
2 participants