mentions : make @-mentions tappable to navigate to user profiles #1899
+112
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Before we can review this PR, it will need a test, as described in the general instructions in the repo's README. |
loveucifer
force-pushed
the
feature/tappable-mentions
branch
from
ff98235 to
0722254
Compare
loveucifer
force-pushed
the
feature/tappable-mentions
branch
from
0722254 to
0194098
Compare
loveucifer
changed the title
rajveermalviya
requested changes
Oct 27, 2025
There was a problem hiding this comment.
Thanks @loveucifer! Sorry for delayed intial review. Comments below.
Also please update the tests in test/model/content_test.dart accordingly.
Comment on lines
1220
to
1258
| final userId = node.userId; | ||
|
|
||
| final innerContent = InlineContent( | ||
| // If an @-mention is inside a link, let the @-mention override it. | ||
| recognizer: null, | ||
| // One hopes an @-mention can't contain an embedded link. | ||
| // (The parser on creating a UserMentionNode has a TODO to check that.) | ||
| linkRecognizers: null, | ||
|
|
||
| style: ambientTextStyle, | ||
|
|
||
| nodes: node.nodes); | ||
|
|
||
| if (userId != null && userId > 0) { | ||
| // Wrap with gesture detector if we have a valid user ID | ||
| return GestureDetector( | ||
| onTap: () => Navigator.push( | ||
| context, | ||
| ProfilePage.buildRoute(context: context, userId: userId), | ||
| ), | ||
| child: Container( | ||
| decoration: BoxDecoration( | ||
| // TODO(#646) different for wildcard mentions | ||
| color: contentTheme.colorDirectMentionBackground, | ||
| borderRadius: const BorderRadius.all(Radius.circular(3))), | ||
| padding: const EdgeInsets.symmetric(horizontal: 0.2 * kBaseFontSize), | ||
| child: innerContent, | ||
| ), | ||
| ); | ||
| } else { | ||
| // Regular container without gesture detector if no valid user ID | ||
| return Container( | ||
| decoration: BoxDecoration( | ||
| // TODO(#646) different for wildcard mentions | ||
| color: contentTheme.colorDirectMentionBackground, | ||
| borderRadius: const BorderRadius.all(Radius.circular(3))), | ||
| padding: const EdgeInsets.symmetric(horizontal: 0.2 * kBaseFontSize), | ||
| child: innerContent); | ||
| } |
There was a problem hiding this comment.
nit, this is doing the same right?
Suggested change
| final userId = node.userId; | |
| final innerContent = InlineContent( | |
| // If an @-mention is inside a link, let the @-mention override it. | |
| recognizer: null, | |
| // One hopes an @-mention can't contain an embedded link. | |
| // (The parser on creating a UserMentionNode has a TODO to check that.) | |
| linkRecognizers: null, | |
| style: ambientTextStyle, | |
| nodes: node.nodes); | |
| if (userId != null && userId > 0) { | |
| // Wrap with gesture detector if we have a valid user ID | |
| return GestureDetector( | |
| onTap: () => Navigator.push( | |
| context, | |
| ProfilePage.buildRoute(context: context, userId: userId), | |
| ), | |
| child: Container( | |
| decoration: BoxDecoration( | |
| // TODO(#646) different for wildcard mentions | |
| color: contentTheme.colorDirectMentionBackground, | |
| borderRadius: const BorderRadius.all(Radius.circular(3))), | |
| padding: const EdgeInsets.symmetric(horizontal: 0.2 * kBaseFontSize), | |
| child: innerContent, | |
| ), | |
| ); | |
| } else { | |
| // Regular container without gesture detector if no valid user ID | |
| return Container( | |
| decoration: BoxDecoration( | |
| // TODO(#646) different for wildcard mentions | |
| color: contentTheme.colorDirectMentionBackground, | |
| borderRadius: const BorderRadius.all(Radius.circular(3))), | |
| padding: const EdgeInsets.symmetric(horizontal: 0.2 * kBaseFontSize), | |
| child: innerContent); | |
| } | |
| Widget widget = Container( | |
| decoration: BoxDecoration( | |
| // TODO(#646) different for wildcard mentions | |
| color: contentTheme.colorDirectMentionBackground, | |
| borderRadius: const BorderRadius.all(Radius.circular(3))), | |
| padding: const EdgeInsets.symmetric(horizontal: 0.2 * kBaseFontSize), | |
| child: InlineContent( | |
| // If an @-mention is inside a link, let the @-mention override it. | |
| recognizer: null, // TODO(#1867) make @-mentions tappable, for info on user | |
| // One hopes an @-mention can't contain an embedded link. | |
| // (The parser on creating a UserMentionNode has a TODO to check that.) | |
| linkRecognizers: null, | |
| // TODO(#647) when self-user is non-silently mentioned, make bold, and: | |
| // TODO(#646) when self-user is non-silently mentioned, | |
| // distinguish font color between direct and wildcard mentions | |
| style: ambientTextStyle, | |
| nodes: node.nodes)); | |
| if (node.userId == null) return widget; | |
| return GestureDetector( | |
| onTap: () { | |
| Navigator.push(context, | |
| ProfilePage.buildRoute(context: context, userId: node.userId!)); | |
| }, | |
| child: widget); |
- Make userId required in UserMentionNode for explicit parameters - Reorder constructor parameters - Refactor UserMention widget to avoid code duplication - Move tests to content_test.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mentions: Enable navigation to user profiles on tap on chat threads
Before, tapping on an @-mention in a message had no effect. This
was inconsistent with tapping a sender's name or avatar, which
navigates to their profile in the thread . This change makes @-mentions tappable to
provide a consistent user experience and match web functionality as mentioned in the issue
The HTML parser extracts the
data-user-id" attribute from the mention'selement and stores it in theUserMentionNode. TheUserMentionwidget uses this "id" to wrap the text in aGestureDetector`,navigating to the user's profile page on tap.
Working Demo
zulip.mp4
Fixes : #1867