KaTeX overline underline border #1919
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,12 +42,13 @@ class KatexWidget extends StatelessWidget { | |
| Widget build(BuildContext context) { | ||
| Widget widget = _KatexNodeList(nodes: nodes); | ||
|
|
||
| return IntrinsicWidth( | ||
|
There was a problem hiding this comment. Can you explain the reasoning behind this change? If it is needed, then it should have it's own separate commit. There was a problem hiding this comment. without 
|
||
| child: Directionality( | ||
| textDirection: TextDirection.ltr, | ||
| child: DefaultTextStyle( | ||
| style: mkBaseKatexTextStyle(textStyle).copyWith( | ||
| color: ContentTheme.of(context).textStylePlainParagraph.color), | ||
| child: widget))); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -122,6 +123,19 @@ class _KatexSpan extends StatelessWidget { | |
| Color.fromARGB(katexColor.a, katexColor.r, katexColor.g, katexColor.b), | ||
| null => null, | ||
| }; | ||
| if (styles.borderStyle case final borderStyle?) { | ||
| final currentColor = color ?? DefaultTextStyle.of(context).style.color!; | ||
| final Color borderColor = borderStyle.color != null | ||
| ? Color.fromARGB(borderStyle.color!.a, borderStyle.color!.r, borderStyle.color!.g, borderStyle.color!.b) | ||
| : currentColor; | ||
| final double borderWidth = borderStyle.widthEm * em; | ||
|
|
||
| return Container( | ||
| constraints: const BoxConstraints(minWidth: double.infinity), | ||
| height: borderWidth, | ||
| color: borderColor, | ||
| ); | ||
| } | ||
|
Comment on lines
127
to
140
There was a problem hiding this comment. Continued from #1919 (comment). The return here ends up discarding the base widget, again is there a reason to not use There was a problem hiding this comment. sorry about discarding base widget, this change should be fine I think widget = Container(
constraints: const BoxConstraints(minWidth: double.infinity),
decoration: BoxDecoration(
border: Border(bottom: BorderSide(color: borderColor, width: borderWidth))),
child: widget,
);about |
||
|
|
||
| TextStyle? textStyle; | ||
| if (fontFamily != null || | ||
|
|
@@ -232,11 +246,11 @@ class _KatexVlist extends StatelessWidget { | |
| Widget build(BuildContext context) { | ||
| final em = DefaultTextStyle.of(context).style.fontSize!; | ||
|
|
||
| return IntrinsicWidth(child: Stack(children: List.unmodifiable(node.rows.map((row) { | ||
|
||
| return Transform.translate( | ||
| offset: Offset(0, row.verticalOffsetEm * em), | ||
| child: _KatexSpan(row.node)); | ||
| })))); | ||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, can you explain the reasoning for ignoring all these classes? I see many here that we already handle in some way.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for lack of explanation.
with
forceRenderKatexoff, the katex code kept falling back to source code, so I ignored all possible warnings, but actually by just ignoring overline and underline case the fallback problem was averted. So these cases can be removed.The reason of this:
is that \overline or \underline and \overline-line or \underline-line are parent-child constructs and by assigning borderStyle to both, the parser ends up with a redundant border on the outer wrapper, and that gives this error ---
ignoring those fixes the issue and also matches KaTeX’s expected DOM structure for \overline{AB}.