Add reusable EmojiWidget #1928
Open
Add reusable EmojiWidget #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-emoji-widget
branch
from
f25380a to
ef29c09
Compare
|
Revision pushed, fixing a bug where I forgot to use ef29c09 settings [nfc]: Centralize logic for checking device animation settings |
chrisbobbe
force-pushed
the
pr-emoji-widget
branch
from
ef29c09 to
9ab45a0
Compare
rajveermalviya
approved these changes
Oct 23, 2025
lib/widgets/user.dart
Outdated
| emojiDisplay: emojiDisplay, | ||
| squareDimension: size, | ||
| neverAnimateImage: neverAnimate, | ||
| imageAnimationMode: ImageAnimationMode.animateNever, |
There was a problem hiding this comment.
Should this respect the value of neverAnimate?
There was a problem hiding this comment.
Ooh, yes, thanks for the catch!
This makes the caller a bit more verbose, but we're about to make it simpler than it was before.
This makes the caller a bit more verbose, but we're about to make it simpler than it was before.
There are several places where we switch on EmojiDisplay, mostly with TODOs to factor the switch out to something central. Here's a widget to accomplish that factoring, used first in ReactionChip.
…quare Instead of laying out - just padding, in the case where the network request failed, and - nothing, in the case where the URL didn't parse.
chrisbobbe
force-pushed
the
pr-emoji-widget
branch
from
9ab45a0 to
3d7da28
Compare
|
Thanks for the review! Revision pushed. |
rajveermalviya
approved these changes
Oct 24, 2025
rajveermalviya
added
integration review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1926.
This resolves a few TODOs, and will be useful toward