notif: Change account when opening a notification, if different account #1993
+61
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, opening a notification from a different account would leave the home page on a different account than the newly opened message list. Now, if the notification's account is different from currently viewing account, we change the whole navigation stack: pop all routes, push HomePage, push MessageList Fixes: zulip#1210
rajveermalviya
added
the
maintainer review
chrisbobbe
reviewed
Nov 21, 2025
Collaborator
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Thanks! LGTM, marking for Greg's review.
chrisbobbe
added
integration review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, opening a notification from a different account would leave the home page on a different account than the newly opened message list.
Now, if the notification's account is different from currently viewing account, we change the whole navigation stack: pop all routes, push HomePage, push MessageList
Fixes: #1210