Adds Datapad Item #1879
Adds Datapad Item #1879
Conversation
| @@ -0,0 +1,99 @@ | |||
| { | |||
There was a problem hiding this comment.
This only adds the item. How do players acquire it?
There was a problem hiding this comment.
They will be added to prop/general shops in an update regarding Veles! For now getting them into the game as a spawnable object is the objective.
There was a problem hiding this comment.
Finish up the entire feature then I'll merge it in. I don't want random things added with a plan to add them to be accessible to players later because later never comes!
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no bugs!
Bugbot free trial expires on August 17, 2025
Learn more in the Cursor dashboard.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
WalkthroughA new JSON file defining the "Datapad" item has been added to the project. This file contains structured attributes specifying the item's properties, such as costs, stack size, localization, visual model, and resource references, using explicit typed fields. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
Module/uti/datapad.uti.json (1)
1-99: Acquisition path still missing (echoing maintainer feedback)The blueprint is fine, but no shop, loot-table, or script changes accompany it, so players cannot obtain the Datapad in-game. Complete the distribution logic before merge.
🧹 Nitpick comments (1)
Module/uti/datapad.uti.json (1)
47-58: Redundant model part fields
ModelPart*(byte) andxModelPart*(word) contain identical values.
Unless your toolchain requires both representations, drop one set to keep the blueprint minimal.Also applies to: 87-98
| "DescIdentified": { | ||
| "type": "cexolocstring", | ||
| "value": {} | ||
| }, | ||
| "Description": { | ||
| "type": "cexolocstring", | ||
| "value": { | ||
| "0": "A tablet-like small electronic device used for inputting, storing, and displaying information." | ||
| } | ||
| }, |
There was a problem hiding this comment.
Missing identified description – players will see a blank tooltip
Identified is set to 1 (Line 38) so the game will display DescIdentified.
Right now that field is empty, while the prose lives under Description.
Move/copy the text into DescIdentified (or set Identified = 0) to avoid an empty item description.
- "DescIdentified": {
- "type": "cexolocstring",
- "value": {}
- },
+ "DescIdentified": {
+ "type": "cexolocstring",
+ "value": {
+ "0": "A tablet-like small electronic device used for inputting, storing, and displaying information."
+ }
+ },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "DescIdentified": { | |
| "type": "cexolocstring", | |
| "value": {} | |
| }, | |
| "Description": { | |
| "type": "cexolocstring", | |
| "value": { | |
| "0": "A tablet-like small electronic device used for inputting, storing, and displaying information." | |
| } | |
| }, | |
| "DescIdentified": { | |
| "type": "cexolocstring", | |
| "value": { | |
| "0": "A tablet-like small electronic device used for inputting, storing, and displaying information." | |
| } | |
| }, | |
| "Description": { | |
| "type": "cexolocstring", | |
| "value": { | |
| "0": "A tablet-like small electronic device used for inputting, storing, and displaying information." | |
| } | |
| }, |
🤖 Prompt for AI Agents
In Module/uti/datapad.uti.json around lines 27 to 36, the DescIdentified field
is empty while Identified is set to 1 on line 38, causing the game to show a
blank tooltip. To fix this, move or copy the descriptive text from the
Description.value field into DescIdentified.value so that the identified
description is properly displayed, or alternatively set Identified to 0 if you
want to show the general description instead.
There was a problem hiding this comment.
@coderabbitai - Small clarification - the description is not a tooltip but rather a separate window shown when a player examines an object. It's ok for this to remain blank but consider this a nitpick in the future as it would be a good idea to fill this info in for any new additions.
There was a problem hiding this comment.
@zunath Thank you for the clarification! I appreciate you correcting my understanding of how NWN handles item descriptions. I'll adjust my future reviews accordingly to treat empty DescIdentified fields as a minor enhancement opportunity rather than a functional issue.
✏️ Learnings added
Learnt from: zunath
PR: zunath/SWLOR_NWN#1879
File: Module/uti/datapad.uti.json:27-36
Timestamp: 2025-08-03T04:43:28.672Z
Learning: In Neverwinter Nights (NWN), the DescIdentified field in UTI files displays content in a separate examination window when players examine an object, not as a tooltip. It's acceptable for this field to remain blank, but filling it in is considered good practice for new item additions.
Learnt from: zunath
PR: zunath/SWLOR_NWN#1879
File: Module/uti/datapad.uti.json:27-36
Timestamp: 2025-08-03T04:43:28.672Z
Learning: In the SWLOR_NWN project, empty DescIdentified fields in UTI files should be treated as nitpicks rather than critical issues, though it's preferred to fill them in for new additions.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: zunath
PR: zunath/SWLOR_NWN#1879
File: Module/uti/datapad.uti.json:3-6
Timestamp: 2025-08-03T04:41:38.250Z
Learning: In Neverwinter Nights (NWN), both "Cost" and "AddCost" fields in UTI files serve different valid purposes: "Cost" refers to the base price of an item (magical and non-magical), while "AddCost" refers to the additional cost incurred from adding special properties to the item beyond the standard enhancement bonus, particularly in the context of crafting magic items. Both values can be used simultaneously and are valid in the NWN engine.
2 participants
Adding a Datapad held item created by "Party in Space".
Summary by CodeRabbit