Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discovery): correctly handle up/down commands for covers #3916

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

robertsLando
Copy link
Member

Fixes #3862

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11104103064

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 32 (6.25%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 21.03%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/lib/Gateway.ts 1 31 3.23%
Totals Coverage Status
Change from base Build 11071550807: -0.03%
Covered Lines: 3925
Relevant Lines: 19843

💛 - Coveralls

@robertsLando robertsLando merged commit 1582b2a into master Sep 30, 2024
4 of 8 checks passed
@robertsLando robertsLando deleted the fix-cover-up-down branch September 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shutter recognized as dimmer
2 participants