Fix consecutive cursors being filtered out #3823
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in `DoTextEvent` is quite hard to understand. Why do we clamp an existing event here? Because we recalculate the end location which should have been assigned before in `ExecuteTextEvent`. The end locations for all `TextEventInsert` are incorrectly being stored in the undo stack and are hot-fixed while being processed. This also fixes potential issues with `TextEventReplace` in regards to multi-line strings.
Getting the remaining characters after line breaks is a common task when dealing with TextEvents. So make it a utility function and expose it to Lua. This is very useful when processing these events in Lua plugins.
…Remove`, `TextEventInsert`) When pasting from the clipboard with multiple cursors, cursors that are directly next to each other are filtered out. The reason for this is that `EventHandler.Replace` triggers two separate events to mimic the replacement. These two events are processed sequentially in `DoTextEvent`, which means that these two consecutive cursors have the same position after `TextEventRemove`. The second event `TextEventInsert`, can no longer distinguish between them, and Buffer.MergeCursors filters out one cursor later.
After replacing text, it is (imho) helpful to undo/redo changes individually. With a single cursor, nothing changes, but with multiple cursors, this gives the user a greater sense of control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pasting from the clipboard (or inserting) with multiple cursors, cursors that are directly next to each other are filtered out.
The reason for this is that
EventHandler.Replacetriggers two separate events to mimic the replacement. These two events are processed sequentially inDoTextEvent, which means that these two consecutive cursors have the same position afterTextEventRemove. The second eventTextEventInsert, can no longer distinguish between them, andBuffer.MergeCursorsfilters out one cursor later.How to reproduce:
Create 2 cursors with selections directly next to each other. Each cursor selects one
c.Insert any character, e.g.
xor paste your clipboard.Expectation:
Actual behavior:
So, one cursor gets lost.
The last commit (
Always stop Undo(), Redo() after TextEventReplace) is totally subjective and up for debate. For me personally it feels much better to have more control forTextEventReplaceundos/redos. Let me know what you think.