-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for additional C++ file extensions from VSCode #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ikos3k
wants to merge
1
commit into
zyedidia:master
Choose a base branch
from
ikos3k-forks:cpp-syntax
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't read or write C++ code, so I think you should not change anything based on this comment only and maybe wait until someone else comments.
A part of this change is good, since it seems to add filename extensions for C++20 modules. There currently seems to be a lot: https://stackoverflow.com/questions/75733706/what-is-the-file-extension-naming-convention-for-c20-modules
There are the only changes I suggest, from left to right in the changed line:
\\.c(c(m)?|pp(m)?|xx(m)?|\\+\\+m?)$→\\.c(c|pp|xx|\\+\\+)m?$\\.i(i)?$→\\.ii?$: Revert, since it should probably be understood as "basic" syntax of regex that this matchesexample.iino: Remove since this is likely for Arduino code, which has a different file in Micro:arduino.yamlMaybe
\.h(pp)?\\.in$should be removed, since I'm not sure we should recognize.innow incpp.yamlonly. Instead, Micro should probably ignore this on all filetypes.I believe
.incan be files in any language, with text like@PREFIX@which a project's build system replaces. Actual examples I've seen are configuration, scripts, and patches.