Pad regex before searching in buffer #3913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile an additional regex on each pad mode before searching in a buffer, to return errors that could occur on padding regardless if the mode will be used. This mainly addresses \Q without \E. Co-authored-by: matthias314 <[email protected]>
Merged
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on a part of a branch I have which is a rebase of #3658, and includes the fix with displaying error messages on
Find*actions. Please see the comments and commit message for slightly detailed explanations.Unlike this patch, the error is returned and can be checked.
It was suggested in #3658 to name the type as
RegexpSearch, but I chose a different name because it sounds like it would have methods and be search state of only one buffer, unlikeRegexpGroup.I also haven't been able to check and test the changes enough, so testing would be appreciated too.
Fixes #3700