New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings in package.json for better typescript support. #18

Merged

ihadeed merged 1 commit into zyra:master from sunshineo:pr1

Oct 7, 2016

Contributor

sunshineo commented Oct 5, 2016

This is needed because everything in the project is put in the dist folder. Otherwise I had to import like this

import { FacebookService } from 'ng2-facebook-sdk/dist'

With the change, I can do

import { FacebookService } from 'ng2-facebook-sdk'

For why, read https://www.typescriptlang.org/docs/handbook/module-resolution.html
11. /root/node_modules/moduleB/package.json (if it specifies a "typings" property)


          Add typings in package.json for better typescript support.

5ee60a4

ihadeed merged commit 11034ee into zyra:master

Member

ihadeed commented Oct 7, 2016

Thanks @sunshineo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet