Added errors catch #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadeed
reviewed
Mar 21, 2017
src/ng2-facebook-sdk.ts
Outdated
| } | ||
| }, options); | ||
| } catch (err) { | ||
| console.error('FB is not defined'); |
There was a problem hiding this comment.
Why did you assume here that the only error that could happen is FB is not defined?
ihadeed
requested changes
Mar 21, 2017
src/ng2-facebook-sdk.ts
Outdated
| } | ||
| }); | ||
| } catch (err) { | ||
| console.error(err); |
There was a problem hiding this comment.
Since we already have a promise here, we could reject the promise with the given error instead of logging it to the console.
Please apply this change to the other promises below.
There was a problem hiding this comment.
it was my extra fix for users with blocked access to Facebook.
You are right, i will change my pull request in the near future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.