Feat: Enable smart confidential transfers in agentkit

[nlok5923]

This pull request introduces significant updates to the agentkit-core package, including the removal of the CONTRIBUTING.md file, the addition of new dependencies, and the implementation of two new actions: SmartConfidentialTransferAction and SmartDepositAction. These changes enhance the functionality for confidential token transfers and deposits on Avalanche C-Chain. Below is a breakdown of the most important changes:

Documentation Changes:

• Removal of CONTRIBUTING.md: The contributing guide has been entirely removed, including setup instructions, development tools, and guidelines for adding actions and toolkits.

Dependency Updates:

• Addition of petcrypt-js-lite: A new dependency (petcrypt-js-lite version 1.0.8) has been added to support confidential token transfers.

New Actions for Confidential Transfers and Deposits:

Confidential Transfers:

• SmartConfidentialTransferAction Implementation: Added a new action to perform confidential transfers of USDC tokens on Avalanche C-Chain. This includes input validation, transaction creation, and confirmation handling.

Token Deposits:

• SmartDepositAction Implementation: Introduced an action to deposit USDC tokens for confidential transfers on Avalanche C-Chain. This includes approval and deposit transactions using gasless smart accounts.

Minor Guidance Update:

• getBalanceAction Usage Guidance: Updated the usage guidance to clarify that the tool should not be used for private or confidential balances.

[puterhimself]

PR #14 Review Summary
✅ Successfully checked out and reviewed PR #14

Overall Assessment: NEEDS WORK ⚠️
This PR introduces confidential transfer functionality but has several issues that need to be addressed before merging.

Key Features Added:
Confidential Transfer Actions:

SmartConfidentialTransferAction - Private USDC transfers on Avalanche
SmartDepositAction - Deposit USDC for confidential transfers
SmartWithdrawTokenAction - Withdraw from confidential balance
GetConfidentialBalanceAction - Check private balances
New Dependency:

✅ Added [email protected] for confidential transfer functionality
✅ Added sqlite3@^5.1.7 for database operations
Documentation Changes:

❌ CONTRIBUTING.md completely removed - This is concerning as it removes valuable contribution guidelines
Critical Issues Found:

1. Build Failures 🚨
   TypeScript errors: Cannot find module petcrypt-js-lite
   Lint errors: 4 unused variables in confidential transfer actions
   Dependencies: Missing type declarations for petcrypt-js-lite
2. Code Quality Issues ⚠️
   Unused functions: Multiple helper functions defined but never used
   Console.log statements: Debug logging left in production code (withdrawTokenAction.ts:98)
   Error messages: Some error messages reference wrong action ("Error depositing asset" in transfer/withdraw)
3. Limited Scope ⚠️
   Single chain: Only supports Avalanche C-Chain (43114)
   Single token: Only supports USDC transfers
   No tests: No test files provided for the new functionality
   Positive Aspects:
   Good Architecture:

✅ Follows existing action patterns
✅ Proper Zod schema validation
✅ Clear separation of concerns
Comprehensive Functionality:

✅ Complete workflow: deposit → transfer → withdraw
✅ Balance checking for confidential tokens
✅ Proper integration with existing action system
Documentation:

✅ Good JSDoc comments
✅ Clear action descriptions and examples
✅ Updated balance action guidance
Security Considerations:
✅ Uses established petcrypt-js-lite library for encryption
✅ Proper input validation with Zod schemas
✅ Gasless transactions via existing infrastructure
Recommendations:
Must Fix Before Merge:
Fix build errors: Ensure petcrypt-js-lite types are available
Remove unused code: Clean up unused helper functions
Fix lint errors: Address all linting issues
Restore CONTRIBUTING.md: This file provides valuable guidance
Should Fix:
Add tests: Create test files for new actions
Remove debug logs: Clean up console.log statements
Fix error messages: Use appropriate error messages for each action
Add error handling: More robust error handling for edge cases
Nice to Have:
Expand support: Consider multi-chain support in future
More tokens: Support for additional tokens beyond USDC
Performance: Optimize transaction batching
Recommendation: ❌ REQUEST CHANGES
While the confidential transfer functionality is valuable, the PR has critical build issues and code quality problems that must be addressed before merging. The removal of CONTRIBUTING.md is also concerning and should be reverted.

Priority fixes needed:

Resolve build/compilation errors
Fix lint issues
Restore CONTRIBUTING.md
Add basic tests