client: add per-client filter lists ui#8275
Open
fegauthier-paragon wants to merge 2 commits intoAdguardTeam:masterfrom
Open
client: add per-client filter lists ui#8275fegauthier-paragon wants to merge 2 commits intoAdguardTeam:masterfrom
fegauthier-paragon wants to merge 2 commits intoAdguardTeam:masterfrom
Conversation
|
I ran into an unexpected issue while reviewing this PR. Please try again later. |
fegauthier-paragon
force-pushed
the
feat/per-client-filter-lists
branch
from
4987902 to
76c3b08
Compare
Add the ability to assign specific blocklists and allowlists to individual clients. When UseOwnFilterLists is true, only the assigned filter lists apply to that client instead of the global ones. User rules (ID 0) always apply regardless of assignment. All filters are now loaded into the engine even when globally disabled, so that per-client assignments work for any filter. Globally-disabled filters are excluded at match time for clients using global settings.
Add a new "Filter lists" tab in the client settings modal allowing admins to toggle specific blocklists and allowlists per client. When "Use global filter lists" is off, individual filters can be selected. The layout uses a two-column grid for filter entries.
fegauthier-paragon
force-pushed
the
feat/per-client-filter-lists
branch
from
76c3b08 to
b3315da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the backend changes from #8274 plus the frontend implementation.
Backend
UseOwnFilterLists,FilterListIDs, andAllowFilterListIDsfields to the client data modelmatchHost()Frontend
Record<string, boolean>in the form maps tonumber[]in the APITest plan
go test ./internal/filtering/...passesgo test ./internal/client/...passesgo test ./internal/home/...passesnpm run build-prodcompiles successfully