Move to vite based build system to be able to keep site up to date with security vuls#1523
Open
karianna wants to merge 15 commits intoAdoptOpenJDK:masterfrom
Open
Move to vite based build system to be able to keep site up to date with security vuls#1523karianna wants to merge 15 commits intoAdoptOpenJDK:masterfrom
karianna wants to merge 15 commits intoAdoptOpenJDK:masterfrom
Conversation
✅ Deploy Preview for vibrant-hugle-19d716 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
nice refactor! I see two issues though:
|
gdams
reviewed
May 13, 2025
gdams
reviewed
May 13, 2025
Member
Author
Yeah oddly these both work fine for me locally when running npm run dev, so I suspect a subtle deploy difference there. |
Member
Author
|
@gdams - I think this can go another review now. There's some CORS stuff which can stop the Adoptium API from responding but that's a local dev thing which you can work around. Would be good to re-trigger netlify but not sure how to do that just yet! |
gdams
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.