add neopixel status; fix baud=0 issue; improve debug output#50
Open
tve wants to merge 1 commit intoBeyondRobotix:masterfrom
Open
add neopixel status; fix baud=0 issue; improve debug output#50tve wants to merge 1 commit intoBeyondRobotix:masterfrom
tve wants to merge 1 commit intoBeyondRobotix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a number of fixes / improvements. I don't really expect it to be mergeable as-is and would appreciate what is desirable and what isn't.
On my esp8266 board I added a neopixel to show the status of the link using colors. Pretty simple and useful, but obviously not everyone has or wants that. Code could be wrapped in a #define or could add a config param.
I added a fix for the issue mentioned at the end of #47, which is that if the baud rate ends up being set to 0 the sketch crashes.
I added additional debug output, added CR for the LF-terminated lines, and enabled the Espressif SDK debug output. I find that when things don't work the more info I get the better. It doesn't spew stuff during normal operation, so I don't think it has any effect on performance.