Skip to content

Conversation

linehill
Copy link
Collaborator

@linehill linehill commented Aug 2, 2024

  • Fixed LLVM passes for LLVM-19.

  • Changed chipStar configuration to prefer llvm-spirv with version suffix which matches to the chosen LLVM (e.g. llvm-spirv-19).

  • Update README and scripts/configure_llvm.sh.

  • New in clang-19: clang's SPIR-V and HIPSPV toolchain picks llvm-spirv-XX (when found in PATH or installed alongside the clang binary) where XX matches to the clang's major version. This should resolve the llvm-spirv issue reported in Build fails on Ubuntu 24.04 #824.

TODOs before the PR is ready for landing:

@linehill linehill marked this pull request as ready for review August 12, 2024 06:39
* Fixed LLVM passes for LLVM-19.

* Changed chipStar configuration to prefer llvm-spirv with version
  suffix which matches to the chosen LLVM (e.g. `llvm-spirv-19`).

* Update README and scripts/configure_llvm.sh.

* New in clang-19: clang's SPIR-V and HIPSPV toolchain picks
  `llvm-spirv-XX` (when found in PATH or installed alongside the clang
  binary) where XX matches to the clang's major version. This should
  resolve the llvm-spirv issue reported in #824.
@pvelesko
Copy link
Collaborator

CMake Error at /home/pvelesko/space/chipStar/main/llvm-project/clang/CMakeLists.txt:211 (message):
  GCC_INSTALL_PREFIX is deprecated and will be removed.  Use configuration
  files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)to
  specify the default --gcc-install-dir= or --gcc-triple=.  --gcc-toolchain=
  is discouraged.  See https://github.com/llvm/llvm-project/pull/77537 for
  detail.


-- Configuring incomplete, errors occurred!
See also "/home/pvelesko/space/chipStar/main/llvm-project/llvm/build_19/CMakeFiles/CMakeOutput.log".
See also "/home/pvelesko/space/chipStar/main/llvm-project/llvm/build_19/CMakeFiles/CMakeError.log".

@pvelesko pvelesko merged commit 8411f51 into main Aug 19, 2024
31 of 32 checks passed
@pvelesko pvelesko deleted the llvm-19 branch August 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants