fix token mail not working with custom Controller config + fix tests failing with latest cake #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
commented
Apr 4, 2025
| @@ -197,8 +197,7 @@ public function getRegisterValidators($options) | |||
| $validateEmail = $options['validate_email'] ?? null; | |||
| $useTos = $options['use_tos'] ?? null; | |||
|
|
|||
| $validator = $this->_table->validationDefault(new Validator()); | |||
| $validator = $this->_table->validationRegister($validator); | |||
There was a problem hiding this comment.
This caused problems because the default validation rules would be loaded twice.
|
thank you @LordSimal ! |
|
Any plans on doing a release for this? 😁 |
|
on it now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone configures their instance to use a custom controller and table class like so in their
config/users.phpthe mail for a one time login URL doesn't work since it was hardcoded to use the UsersController, therefore causing a Router exception.
Basically (as far as I can see) there should never be
'controller' => 'Users',anywhere in thesrcdirectory of this plugin, since all the Urls should be generated via theUsersUrlUtility to make sure it respects the users config.Also latest cake requires rule names to be unique, therefore I just adjusted the already existing ones to make the CI green again.