chore: Easier way to delete snapshots for old AMIs #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the deletion of snapshots for outdated AMIs by updating asset references and leveraging the AWS SDK's built-in capability to delete associated snapshots.
- Consolidated asset hash updates in JSON templates.
- Removed the manual snapshot deletion loop from the Lambda function.
- Added the "DeleteAssociatedSnapshots" flag to automate snapshot deletion.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/default.integ.snapshot/github-runners-test.template.json | Updated S3Key to reference the new asset hash |
| test/default.integ.snapshot/github-runners-test.assets.json | Updated asset key identifiers and corresponding objectKey values |
| src/image-builders/aws-image-builder/delete-resources.lambda.ts | Simplified resource deletion by removing the manual snapshot deletion loop and using DeleteAssociatedSnapshots |
Comments suppressed due to low confidence (1)
src/image-builders/aws-image-builder/delete-resources.lambda.ts:72
- Verify that the 'DeleteAssociatedSnapshots' flag is supported by the current AWS SDK version and behaves as expected to automatically remove associated snapshots.
DeleteAssociatedSnapshots: true,
| @@ -9556,7 +9556,7 @@ | |||
| "S3Bucket": { | |||
| "Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}" | |||
| }, | |||
| "S3Key": "bfba719fe2a2764d7716a472198f4f8cbe46f6ea4616cd6ba0ebf26e75954814.zip" | |||
| "S3Key": "b97c8701d090be54cf447e094fd55ece7c99b860476949ee5db7ceca6eeb2f6a.zip" | |||
There was a problem hiding this comment.
[nitpick] Consider centralizing asset hash values (and thus S3Key values) to reduce duplication and ease future updates.
Suggested change
| "S3Key": "b97c8701d090be54cf447e094fd55ece7c99b860476949ee5db7ceca6eeb2f6a.zip" | |
| "S3Key": { | |
| "Ref": "LambdaS3Key" | |
| } |
Copilot uses AI. Check for mistakes.
|
Now it's at 3.806.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.