Skip to content

FIX public ticket layout for Safari on macOS (v18) #33739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

W1W1-M
Copy link
Contributor

@W1W1-M W1W1-M commented Apr 6, 2025

FIX public ticket layout for Safari on macOS (v18)

This is a backport for #33728 & #33742

@W1W1-M W1W1-M changed the title FIX public ticket layout for Safari on macOS FIX public ticket layout for Safari on macOS (v18) Apr 7, 2025
@W1W1-M W1W1-M marked this pull request as ready for review April 7, 2025 06:32
@eldy
Copy link
Member

eldy commented Apr 7, 2025

Can you check this PR instead of #33742
d77898f

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Apr 7, 2025
@W1W1-M
Copy link
Contributor Author

W1W1-M commented Apr 8, 2025

@eldy Retested this PR on Safari, MS Edge/Chrome & Firefox. Index, view, list & create layouts are centered and taking up normal width.

@eldy
Copy link
Member

eldy commented Apr 8, 2025

@eldy Retested this PR on Safari, MS Edge/Chrome & Firefox. Index, view, list & create layouts are centered and taking up normal width.

And on smartphone ?
And what about my suggested fix ?

@W1W1-M
Copy link
Contributor Author

W1W1-M commented Apr 9, 2025

@eldy Retested this PR on Safari, MS Edge/Chrome & Firefox. Index, view, list & create layouts are centered and taking up normal width.

And on smartphone ? And what about my suggested fix ?

Removing flexcontainer doesn't help for Safari and seems to also break things for chrome and firefox. I looked closer at the flexcontainer CSS class and noticed Safari was missing from list of browsers used for display: inline-flex.

I've reverted my older fixes and just added Safari to list of browser for flexcontainer and everything is rendering correctly.

As for iPad & iPhone, I still have the problem. I propose to make a separate PR for this (maybe not the same user agent and also need to check getBrowserInfo function).

If this fix is merged, then 72be183 is wrong and needs to be reverted (sorry 🙈)

@W1W1-M
Copy link
Contributor Author

W1W1-M commented Apr 21, 2025

Better fix #33933

@W1W1-M W1W1-M closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants